Add scaling parameter #9493
Open
Add scaling parameter #9493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
akallabeth
requested changes
Oct 20, 2023
| @@ -38,6 +38,7 @@ public class BookmarkDB extends SQLiteOpenHelper | |||
| static final String DB_KEY_SCREEN_RESOLUTION = "resolution"; | |||
| static final String DB_KEY_SCREEN_WIDTH = "width"; | |||
| static final String DB_KEY_SCREEN_HEIGHT = "height"; | |||
| static final String DB_KEY_SCREEN_SCALE = "scale"; | |||
There was a problem hiding this comment.
you need to increment the database version and add an update path for the new field.
| android:entries="@array/scale_array" | ||
| android:entryValues="@array/scale_values_array" | ||
| android:key="bookmark.scale" | ||
| android:summary="Scaling Percentage" |
There was a problem hiding this comment.
- no hard coded strings, move to
strings.xml. - Summary is not really helpful, this is
HighDPIsupport, so remote scaling, not local/smart-sizinglike
| android:entryValues="@array/scale_values_array" | ||
| android:key="bookmark.scale" | ||
| android:summary="Scaling Percentage" | ||
| android:title="@string/settings_scale" /> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is how are pull requests handled by FreeRDP
Preparations before creating a pull
.clang-formatclangformatreformats the whole codebaseTo ease accepting your contribution
What you should be prepared for
Please remove this text before submitting your pull!