New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[sdl] update to SDL3 #9387
[sdl] update to SDL3 #9387
Conversation
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Hi @akallabeth, thanks a lot for your work on this feature, is this port still on going as of right now ? It seems you are most likely busy working on other features at the moment ? Is there any way someone that has no prior knowledge in this codebase help move this forward ? I have little experience with CMake (more with CMake than with C++) I've seen this : https://github.com/libsdl-org/SDL/blob/main/docs/README-migration.md that might be helpful |
@AkechiShiro well, waiting for |
@akallabeth A prerelease was done for SDL3 recently was done : https://github.com/libsdl-org/SDL/releases/tag/prerelease-3.1.0 Just thought you might want to get this news ! |
5c3ce4e
to
616f2e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 25 out of 39. Check the log or trigger a new build to see more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
Any progress so far, I've seen new preview release for SDL3, thanks also for working on this ! |
Refer to this link for build results (access rights to CI server needed): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 25 out of 158. Check the log or trigger a new build to see more.
Refer to this link for build results (access rights to CI server needed): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 25 out of 1197. Check the log or trigger a new build to see more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 25 out of 1057. Check the log or trigger a new build to see more.
Refer to this link for build results (access rights to CI server needed): |
Can this be used yet or tested in any way? Just would like to know if users could beta test and report issues on SDL3's preview version for |
yes.
|
@LDprg @oskardotglobal any of you could do some testing with winapps with this experimental SDL3 backend ? If you cannot, I'll see if I can take some time to do so and report back my findings here so we can squash bugs in advance. |
@hardening @mfleisz @bmiklautz @pnowack I´d appreciate a review (does not have to be thorough) of this pr. this way we can get (at least some) feedback from interested parties. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like a good start. There's probably things that are common between the SDL2 and SDL3 client but this is something we can make common later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 25 out of 1032. Check the log or trigger a new build to see more.
Refer to this link for build results (access rights to CI server needed): |
Refer to this link for build results (access rights to CI server needed): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 25 out of 1007. Check the log or trigger a new build to see more.
@freerdp-bot test again please... |
Refer to this link for build results (access rights to CI server needed): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 25 out of 982. Check the log or trigger a new build to see more.
Refer to this link for build results (access rights to CI server needed): |
* Copy SDL2 client to SDL3 as the new version is not API compatible * Move existing SDL2 client to SDL2 directory * Move fonts from SDL client to resources folder in top level directory
update client for SDL3. Not compatible with SDL2
Allow SDL2 and SDL3 client to be installed side by side as well as an option to only install one and name it accordingly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There were too many comments to post at once. Showing the first 25 out of 961. Check the log or trigger a new build to see more.
Refer to this link for build results (access rights to CI server needed): |
sdl3
,sdl3_image
andsdl3_ttf
SDL2
andSDL3
client installable side by side or replacing each other (configurable)OFF
forSDL3
client build