sdl rails #9169
sdl rails #9169
Conversation
|
Refer to this link for build results (access rights to CI server needed): |
akallabeth
force-pushed
the
sdl_client_rails
branch
2 times, most recently
from
d29fdcb
to
7eb5b17
Compare
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
|
Refer to this link for build results (access rights to CI server needed): |
akallabeth
force-pushed
the
sdl_client_rails
branch
from
ea1d905
to
a50a515
Compare
|
Refer to this link for build results (access rights to CI server needed): |
akallabeth
force-pushed
the
sdl_client_rails
branch
from
a50a515
to
028aea9
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| #include <freerdp/log.h> | ||
| #define TAG CLIENT_TAG("x11") | ||
|
|
||
| static const char* error_code_names[] = { "RAIL_EXEC_S_OK", |
There was a problem hiding this comment.
warning: do not declare C-style arrays, use std::array<> instead [cppcoreguidelines-avoid-c-arrays]
static const char* error_code_names[] = { "RAIL_EXEC_S_OK",
^| { | ||
| } | ||
|
|
||
| SdlRail::~SdlRail() |
There was a problem hiding this comment.
warning: use '= default' to define a trivial destructor [hicpp-use-equals-default]
client/SDL/rails/sdl_rail.cpp:56:
- {
- }
+ = default;| { | ||
| } | ||
|
|
||
| bool SdlRail::show() |
There was a problem hiding this comment.
warning: method 'show' can be made static [readability-convert-member-functions-to-static]
client/SDL/rails/sdl_rail.hpp:41:
- bool show();
+ static bool show();|
|
||
| bool SdlRail::show() | ||
| { | ||
| // TODO |
There was a problem hiding this comment.
warning: missing username/bug in TODO [google-readability-todo]
| // TODO | |
| // TODO(nin): |
| { | ||
| for (auto& it : _windows) | ||
| { | ||
| if (!paint_surface(it.first, rect)) |
There was a problem hiding this comment.
warning: implicit conversion 'BOOL' (aka 'int') -> bool [readability-implicit-bool-conversion]
| if (!paint_surface(it.first, rect)) | |
| if (paint_surface(it.first, rect) == 0) |
| auto margins = appWindow.margins(); | ||
| windowMove.left = rect.x - margins.x; | ||
| windowMove.top = rect.y - margins.y; | ||
| windowMove.right = rect.x + rect.w + margins.w; |
There was a problem hiding this comment.
warning: narrowing conversion from 'int' to signed type 'INT16' (aka 'short') is implementation-defined [bugprone-narrowing-conversions]
windowMove.right = rect.x + rect.w + margins.w;
^| windowMove.left = rect.x - margins.x; | ||
| windowMove.top = rect.y - margins.y; | ||
| windowMove.right = rect.x + rect.w + margins.w; | ||
| windowMove.bottom = rect.y + rect.h + margins.h; |
There was a problem hiding this comment.
warning: narrowing conversion from 'int' to signed type 'INT16' (aka 'short') is implementation-defined [bugprone-narrowing-conversions]
windowMove.bottom = rect.y + rect.h + margins.h;
^| windowMove.right = rect.x + rect.w + margins.w; | ||
| windowMove.bottom = rect.y + rect.h + margins.h; | ||
|
|
||
| WINPR_ASSERT(_rail); |
There was a problem hiding this comment.
warning: avoid do-while loops [cppcoreguidelines-avoid-do-while]
WINPR_ASSERT(_rail);
^Additional context
winpr/include/winpr/assert.h:35: expanded from macro 'WINPR_ASSERT'
do \
^| windowMove.right = rect.x + rect.w + margins.w; | ||
| windowMove.bottom = rect.y + rect.h + margins.h; | ||
|
|
||
| WINPR_ASSERT(_rail); |
There was a problem hiding this comment.
warning: do not implicitly decay an array into a pointer; consider using gsl::array_view or an explicit cast instead [cppcoreguidelines-pro-bounds-array-to-pointer-decay]
WINPR_ASSERT(_rail);
^Additional context
winpr/include/winpr/assert.h:38: expanded from macro 'WINPR_ASSERT'
winpr_int_assert(#cond, __FILE__, __func__, __LINE__); \
^| windowMove.bottom = rect.y + rect.h + margins.h; | ||
|
|
||
| WINPR_ASSERT(_rail); | ||
| WINPR_ASSERT(_rail->ClientWindowMove); |
There was a problem hiding this comment.
warning: avoid do-while loops [cppcoreguidelines-avoid-do-while]
WINPR_ASSERT(_rail->ClientWindowMove);
^Additional context
winpr/include/winpr/assert.h:35: expanded from macro 'WINPR_ASSERT'
do \
^
|
Refer to this link for build results (access rights to CI server needed): |
No description provided.