New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timezone settings #10131
base: master
Are you sure you want to change the base?
Timezone settings #10131
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Refer to this link for build results (access rights to CI server needed): |
a31e033
to
75d48e0
Compare
Refer to this link for build results (access rights to CI server needed): |
convert IANA format timezone strings to windows format.
/timezone now allows setting the timezone used from an IANA string
75d48e0
to
f1aa0df
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
|
||
TIME_ZONE_INFORMATION* winpr_GetWindowsTimezoneFromIANA(const char* tzid) | ||
{ | ||
WCHAR* wzid = tz_map_iana_to_windows(tzid); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: call to undeclared function 'tz_map_iana_to_windows'; ISO C99 and later do not support implicit function declarations [clang-diagnostic-implicit-function-declaration]
WCHAR* wzid = tz_map_iana_to_windows(tzid);
^
|
||
TIME_ZONE_INFORMATION* winpr_GetWindowsTimezoneFromIANA(const char* tzid) | ||
{ | ||
WCHAR* wzid = tz_map_iana_to_windows(tzid); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: incompatible integer to pointer conversion initializing 'WCHAR *' (aka 'unsigned short *') with an expression of type 'int' [clang-diagnostic-int-conversion]
WCHAR* wzid = tz_map_iana_to_windows(tzid);
^
if (!wzid) | ||
return NULL; | ||
|
||
TIME_ZONE_INFORMATION* entry = winpr_get_from_id(tzid, wzid); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: call to undeclared function 'winpr_get_from_id'; ISO C99 and later do not support implicit function declarations [clang-diagnostic-implicit-function-declaration]
TIME_ZONE_INFORMATION* entry = winpr_get_from_id(tzid, wzid);
^
if (!wzid) | ||
return NULL; | ||
|
||
TIME_ZONE_INFORMATION* entry = winpr_get_from_id(tzid, wzid); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: incompatible integer to pointer conversion initializing 'TIME_ZONE_INFORMATION *' with an expression of type 'int' [clang-diagnostic-int-conversion]
TIME_ZONE_INFORMATION* entry = winpr_get_from_id(tzid, wzid);
^
Refer to this link for build results (access rights to CI server needed): |
No description provided.