Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Timezone settings #10131

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

akallabeth
Copy link
Member

No description provided.

@akallabeth akallabeth added this to the next-3.0 milestone Apr 23, 2024
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

winpr/libwinpr/timezone/timezone.c Outdated Show resolved Hide resolved
@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11873/

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11878/

convert IANA format timezone strings to windows format.
/timezone now allows setting the timezone used from an IANA string
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions


TIME_ZONE_INFORMATION* winpr_GetWindowsTimezoneFromIANA(const char* tzid)
{
WCHAR* wzid = tz_map_iana_to_windows(tzid);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: call to undeclared function 'tz_map_iana_to_windows'; ISO C99 and later do not support implicit function declarations [clang-diagnostic-implicit-function-declaration]

	WCHAR* wzid = tz_map_iana_to_windows(tzid);
               ^


TIME_ZONE_INFORMATION* winpr_GetWindowsTimezoneFromIANA(const char* tzid)
{
WCHAR* wzid = tz_map_iana_to_windows(tzid);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: incompatible integer to pointer conversion initializing 'WCHAR *' (aka 'unsigned short *') with an expression of type 'int' [clang-diagnostic-int-conversion]

	WCHAR* wzid = tz_map_iana_to_windows(tzid);
        ^

if (!wzid)
return NULL;

TIME_ZONE_INFORMATION* entry = winpr_get_from_id(tzid, wzid);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: call to undeclared function 'winpr_get_from_id'; ISO C99 and later do not support implicit function declarations [clang-diagnostic-implicit-function-declaration]

	TIME_ZONE_INFORMATION* entry = winpr_get_from_id(tzid, wzid);
                                ^

if (!wzid)
return NULL;

TIME_ZONE_INFORMATION* entry = winpr_get_from_id(tzid, wzid);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

warning: incompatible integer to pointer conversion initializing 'TIME_ZONE_INFORMATION *' with an expression of type 'int' [clang-diagnostic-int-conversion]

	TIME_ZONE_INFORMATION* entry = winpr_get_from_id(tzid, wzid);
                        ^

@freerdp-bot
Copy link

Refer to this link for build results (access rights to CI server needed):
https://ci.freerdp.com//job/PullRequestTester/11949/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants