Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Gui] QSint: fix QGroupBox visibility #7292

Merged
merged 1 commit into from
Aug 1, 2022

Conversation

donovaly
Copy link
Member

@donovaly donovaly commented Jul 31, 2022

  • fixes qwindowsvistastyle.dll does not style the line color #6102
  • the point is that we don't set any style for the group boxes, therefore the windows style steps as nothing was set yet. Its default style is the color #dddddd which is hardly visible on our blue default style.
    as solution set an explicit color and use the grooved style.

This is the result:
FreeCAD_YDnzT5OQyi

@github-actions github-actions bot added the Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD label Jul 31, 2022
@berndhahnebach
Copy link
Contributor

pipeline status for feature branch PR_7292. Pipeline 601196151 was triggered at 10066dc. All CI branches and pipelines.

- the point is that we don't set any style for the group boxes, therefore the Windows style is applied as nothing was set yet. The default Windows style is the color #dddddd which is hardly visible on our blue default style.
as solution set an explicit color.
@berndhahnebach
Copy link
Contributor

pipeline status for feature branch PR_7292. Pipeline 601204606 was triggered at b62e9d0. All CI branches and pipelines.

@Roy-043
Copy link
Contributor

Roy-043 commented Jul 31, 2022

Thanks for working on this, and fixing the true cause of the issue.

@donovaly
Copy link
Member Author

@Roy-043 , I am a bit reluctant about the border color. What is in your opinion better?:

FreeCAD_YDnzT5OQyi FreeCAD_1le8lLJ4Oc

(left is #bbbbbb, right ist #cccccc)

@luzpaz
Copy link
Contributor

luzpaz commented Jul 31, 2022

@donovaly should we let the FreeCAD theme-ers know about this ? (ie FreeCAD/FreeCAD-addons#201)

@donovaly
Copy link
Member Author

donovaly commented Aug 1, 2022

@donovaly should we let the FreeCAD theme-ers know about this ? (ie FreeCAD/FreeCAD-addons#201)

This is not necessary since the various themes use their own style. The fix here is only for the default style - meaning when no style file is applied.

What is your opinion, better the left or right image?

@luzpaz
Copy link
Contributor

luzpaz commented Aug 1, 2022

Right side.

@Roy-043
Copy link
Contributor

Roy-043 commented Aug 1, 2022

I prefer the left image. On the right the contrast is too low IMO.

@GeneGH
Copy link
Contributor

GeneGH commented Aug 1, 2022

I like the left one better, but modern style is to make everything gray on light gray on off-white on white. Very low constrast is the current fad. Great for teenagers; not so great for more "mature" folks.

@adrianinsaval
Copy link
Member

adrianinsaval commented Aug 1, 2022

Left has better contrast IMO, perhaps a blueish color would work better here?
Quick edit on gimp using #a09ebc
image

@luzpaz
Copy link
Contributor

luzpaz commented Aug 1, 2022

too bad the left/right tracks for Transparency and Line-Transparency aren't slightly shadowed. That color doesn't distiguish well from the widget background
Screenshot_20220801_184740

@donovaly
Copy link
Member Author

donovaly commented Aug 1, 2022

Thanks for the feedback.

I made a mistake here: for years nobody really cared and now I triggered a discussion about the right color for a box line. This is not really worth it.

@Roy-043 was insisting that the issue got fixed, so shall it be his choice: :-) -> merging the PR is it is.

@donovaly donovaly merged commit 360d133 into FreeCAD:master Aug 1, 2022
@donovaly donovaly deleted the QGroupBox-scheme-fix branch August 1, 2022 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qwindowsvistastyle.dll does not style the line color
6 participants