Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TechDraw: remove 'Project Shape' from Techdraw toolbar #13655

Merged
merged 1 commit into from
Apr 29, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/Mod/TechDraw/Gui/Workbench.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -64,23 +64,23 @@
qApp->translate("Workbench", "Views");
#endif

TYPESYSTEM_SOURCE(TechDrawGui::Workbench, Gui::StdWorkbench)

Check warning on line 67 in src/Mod/TechDraw/Gui/Workbench.cpp

View workflow job for this annotation

GitHub Actions / Lint / Lint

variable 'classTypeId' is non-const and globally accessible, consider making it const [cppcoreguidelines-avoid-non-const-global-variables]

Workbench::Workbench()

Check warning on line 69 in src/Mod/TechDraw/Gui/Workbench.cpp

View workflow job for this annotation

GitHub Actions / Lint / Lint

use '= default' to define a trivial default constructor [modernize-use-equals-default]
{}

Workbench::~Workbench()

Check warning on line 72 in src/Mod/TechDraw/Gui/Workbench.cpp

View workflow job for this annotation

GitHub Actions / Lint / Lint

use '= default' to define a trivial destructor [modernize-use-equals-default]
{}

Gui::MenuItem* Workbench::setupMenuBar() const
{
Gui::MenuItem* root = StdWorkbench::setupMenuBar();
Gui::MenuItem* item = root->findItem("&Windows");
Gui::MenuItem* draw = new Gui::MenuItem;

Check warning on line 79 in src/Mod/TechDraw/Gui/Workbench.cpp

View workflow job for this annotation

GitHub Actions / Lint / Lint

initializing non-owner 'Gui::MenuItem *' with a newly created 'gsl::owner<>' [cppcoreguidelines-owning-memory]

Check warning on line 79 in src/Mod/TechDraw/Gui/Workbench.cpp

View workflow job for this annotation

GitHub Actions / Lint / Lint

use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
root->insertItem(item, draw);

// dimensions
Gui::MenuItem* dimensions = new Gui::MenuItem;

Check warning on line 83 in src/Mod/TechDraw/Gui/Workbench.cpp

View workflow job for this annotation

GitHub Actions / Lint / Lint

initializing non-owner 'Gui::MenuItem *' with a newly created 'gsl::owner<>' [cppcoreguidelines-owning-memory]

Check warning on line 83 in src/Mod/TechDraw/Gui/Workbench.cpp

View workflow job for this annotation

GitHub Actions / Lint / Lint

use auto when initializing with new to avoid duplicating the type name [modernize-use-auto]
dimensions->setCommand("Dimensions");
*dimensions << "TechDraw_LengthDimension";
*dimensions << "TechDraw_HorizontalDimension";
Expand All @@ -97,7 +97,7 @@
*dimensions << "TechDraw_DimensionRepair";

// extension: attributes and modifications
Gui::MenuItem* toolattrib = new Gui::MenuItem;

Check warning on line 100 in src/Mod/TechDraw/Gui/Workbench.cpp

View workflow job for this annotation

GitHub Actions / Lint / Lint

initializing non-owner 'Gui::MenuItem *' with a newly created 'gsl::owner<>' [cppcoreguidelines-owning-memory]
toolattrib->setCommand("Extensions: Attributes/Modifications");
*toolattrib << "TechDraw_ExtensionSelectLineAttributes";
*toolattrib << "TechDraw_ExtensionChangeLineAttributes";
Expand Down Expand Up @@ -298,7 +298,6 @@
*views << "TechDraw_DetailView";
*views << "TechDraw_DraftView";
*views << "TechDraw_ClipGroup";
*views << "TechDraw_ProjectShape";

Gui::ToolBarItem* stacking = new Gui::ToolBarItem(root);
stacking->setCommand("TechDraw Stacking");
Expand Down Expand Up @@ -400,7 +399,6 @@
*views << "TechDraw_DetailView";
*views << "TechDraw_DraftView";
*views << "TechDraw_ClipGroup";
*views << "TechDraw_ProjectShape";

Gui::ToolBarItem* stacking = new Gui::ToolBarItem(root);
stacking->setCommand("TechDraw Stacking");
Expand Down