Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toponaming/Part move in PyImps #13196

Merged
merged 5 commits into from
Apr 1, 2024
Merged

Toponaming/Part move in PyImps #13196

merged 5 commits into from
Apr 1, 2024

Conversation

bgbsww
Copy link
Contributor

@bgbsww bgbsww commented Mar 28, 2024 •
edited

Python implementations for CompSolid, Face, Shell, Solid as well as missing entries in TopoShape and cleanups from prior PR.

@bgbsww bgbsww marked this pull request as draft March 28, 2024 13:00
@github-actions github-actions bot added Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD WB FEM Related to the FEM Workbench WB BIM Related to the BIM/Arch Workbench WB Draft Related to the Draft Workbench WB TechDraw Related to the TechDraw Workbench WB Part Related to the Part Workbench WB Sketcher Related to the Sketcher Workbench WB Mesh Related to the Mesh Workbench WB ReverseEngineering Related to the Reverse Engineering Workbench WB MeshPart labels Mar 28, 2024
@bgbsww bgbsww force-pushed the bgbsww-toponamingCompSolidPyImp branch from 26c0ef6 to 85d7f30 Compare March 28, 2024 13:20
@bgbsww bgbsww force-pushed the bgbsww-toponamingCompSolidPyImp branch 4 times, most recently from 2b8b593 to 3f114a6 Compare March 28, 2024 14:11
@chennes chennes self-assigned this Mar 28, 2024
@bgbsww bgbsww force-pushed the bgbsww-toponamingCompSolidPyImp branch from 3f114a6 to 4170a5f Compare March 28, 2024 16:16
@bgbsww bgbsww force-pushed the bgbsww-toponamingCompSolidPyImp branch 2 times, most recently from 27c5f20 to 5b66818 Compare March 28, 2024 23:12
@bgbsww bgbsww changed the title Toponaming/Part move in CompSolidPyImp Toponaming/Part move in PyImps Mar 28, 2024
@bgbsww bgbsww force-pushed the bgbsww-toponamingCompSolidPyImp branch 2 times, most recently from 323af6a to 3dc2e2c Compare March 29, 2024 02:44
@FlachyJoe
Copy link
Contributor

@bgbsww does it affect #13208 ?

@bgbsww
Copy link
Contributor Author

bgbsww commented Mar 29, 2024

@bgbsww does it affect #13208 ?

No, that's a standalone bug that I'm not addressing right now. It existed before and will exist after this. I did discover it while working on this PR, but that's really the only connection.

@bgbsww bgbsww force-pushed the bgbsww-toponamingCompSolidPyImp branch 6 times, most recently from 2e0b392 to 9c4153b Compare March 30, 2024 22:39
@bgbsww bgbsww force-pushed the bgbsww-toponamingCompSolidPyImp branch from 9c4153b to c8d5418 Compare March 31, 2024 13:32
@bgbsww bgbsww marked this pull request as ready for review April 1, 2024 13:52
@chennes chennes merged commit 8a6bb88 into FreeCAD:main Apr 1, 2024
9 checks passed
@bgbsww bgbsww deleted the bgbsww-toponamingCompSolidPyImp branch April 2, 2024 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@chennes chennes

Labels
Core Issue or PR touches core sections (App, Gui, Base) of FreeCAD Toponaming WB BIM Related to the BIM/Arch Workbench WB Draft Related to the Draft Workbench WB FEM Related to the FEM Workbench WB Mesh Related to the Mesh Workbench WB MeshPart WB Part Related to the Part Workbench WB ReverseEngineering Related to the Reverse Engineering Workbench WB Sketcher Related to the Sketcher Workbench WB TechDraw Related to the TechDraw Workbench
Projects
Toponaming Integration
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@bgbsww @FlachyJoe @chennes @luzpaz @realthunder