Merge pull request #398 from howetuft/hotfix

Project: check output path for validity

Render/project.py

@@ -418,6 +418,19 @@ def render(self, wait_for_completion=False, skip_meshing=False):
             App.Console.PrintError(msg)
             return None
 
+        # Fetch the rendering parameters
+        params = self._get_rendering_params()
+
+        # Check output consistency
+        if not os.path.exists(os.path.dirname(params.output)):
+            msg = translate(
+                "Render",
+                "[Render][Project] WARNING - Output image path "
+                f"'{params.output}' does not seem to be a valid path on "
+                "your system. This may cause the renderer to fail...\n",
+            )
+            App.Console.PrintWarning(msg)
+
         # Set export directories
         project_directory = self.fpo.Document.TransientDir
         object_directory = os.path.join(project_directory, self.fpo.Name)
@@ -463,9 +476,6 @@ def render(self, wait_for_completion=False, skip_meshing=False):
             instantiated, project_directory
         )
 
-        # Fetch the rendering parameters
-        params = self._get_rendering_params()
-
         # Get the renderer command on the generated temp file, with rendering
         # params
         cmd, img = renderer.render(
@@ -604,7 +614,7 @@ def _get_rendering_params(self):
 
         try:
             output = self.fpo.OutputImage
-            assert output
+            assert output  # TODO don't use assert here
         except (AttributeError, AssertionError):
             fname = f"{self.fpo.Name}_output.png"
             output = os.path.join(self.fpo.Document.TransientDir, fname)