-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for full connection string passed to constructor or con #168
Conversation
…nection string name Allows a full connection string to be passed to the constructor while still supporting the connection string name from config file. This allows for environments or situations where you don't use the a config file. Also renamed ConnectionString to _connectionString to be inlined with visible naming conventions in the file, which is also in line with common conventions for C#.
Moved GetType call out of the if blocks which was calling it up to 4 times, now it is only called once always.
…r or connection string name" This reverts commit 35a9e2c.
…nstructor or connection string name"" This reverts commit 9d91837.
This reverts commit 3fd1d9c.
The original version of this commit 35a9e2c looks like quite a useful change (i.e. if a connection string with the passed-in On a closely related vein, I've been looking through all past issues for discussion of support for
I do fully recognise that with respect to both of my two questions just above, any change would break the existing API. But these might - just possibly - be changes that could be carefully handled in some new version of Massive? I am thinking, e.g., in terms of throwing a |
To be completely clear, the possible problems here (which aren't urgent, and don't need fixing now, but which I perceive as real) are:
|
Allows a full connection string to be passed to the constructor while
still supporting the connection string name from config file. This
allows for environments or situations where you don't use the a config
file. Also renamed ConnectionString to _connectionString to be inlined
with visible naming conventions in the file, which is also in line with
common conventions for C#.