Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update index.d.ts to add export declaration. #462

Closed
wants to merge 2 commits into from

Conversation

shigeyf
Copy link

@shigeyf shigeyf commented May 24, 2023

This fix will resolve the problem (Issue #418) caused by ESlint.

The error message is:

error FontAwesomeIcon not found in '@fortawesome/vue-fontawesome' import/named

jasonlundien and others added 2 commits May 1, 2023 16:16
This fix will resolve a problem caused by ESlint.

> error  FontAwesomeIcon not found in '@fortawesome/vue-fontawesome'  import/named
@ThomasBerneHCSE
Copy link

Any updates on this ? Why hasn't it been merged yet?

@drusellers
Copy link

Also interested in this

@Kwaadpepper
Copy link

I encountered this issue also.

@nclemeur
Copy link

nclemeur commented Feb 1, 2024

Would it be possible to also export FontAwesomeIconProps as I was using it and now I have the error:

error TS2724: '"@fortawesome/vue-fontawesome"' has no exported member named 'FontAwesomeIconProps'. Did you mean 'FontAwesomeIcon'?

@jasonlundien
Copy link
Member

jasonlundien commented May 15, 2024

Hey everyone,

I am not seeing the FontAwesomeIcon not found in '@fortawesome/vue-fontawesome' import/named error using nuxt (my test repo: https://github.com/jasonlundien/fa-nuxt3-ts )

  • I used dependencies from the stackblitz referenced in the initial post of Issue 418.

  • I also have a branch with updated dependencies (nuxt-updated-deps) in the same repo that does not show the error either.

  • I do see a hydration error (which is a known issue) on both branches, but no eslint error.

Does anyone have a test repo they could share that is showing the FontAwesomeIcon not found in '@fortawesome/vue-fontawesome' import/named error ?

@jasonlundien
Copy link
Member

jasonlundien commented May 21, 2024

I do not believe this is needed any longer.
With the Release of 3.0.8, we are now exporting the following props in index.d.ts.

export { FontAwesomeIcon, FontAwesomeIconProps, FontAwesomeLayers, FontAwesomeLayersProps, FontAwesomeLayersText, FontAwesomeLayersTextProps }

If you think we still need something on the PR just let me know.

@jasonlundien
Copy link
Member

jasonlundien commented May 21, 2024

I believe we have the exports fixed up now with the Release of 3.0.8; we are now exporting the following props in index.d.ts.

export { FontAwesomeIcon, FontAwesomeIconProps, FontAwesomeLayers, FontAwesomeLayersProps, FontAwesomeLayersText, FontAwesomeLayersTextProps }

Let us know if anything else pops up.
Thank you,
-jason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants