Skip to content

Commit

Permalink
stop using node 16 in pipelines / clear other pipeline warnings (#1324)
Browse files Browse the repository at this point in the history
  • Loading branch information
Sawyer Burnett committed Mar 12, 2024
1 parent a06f1d1 commit 1dd3a89
Show file tree
Hide file tree
Showing 3 changed files with 23 additions and 58 deletions.
33 changes: 10 additions & 23 deletions .github/workflows/ci.yml
Expand Up @@ -16,33 +16,20 @@ jobs:
build:
name: Check and build codebase
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.x, 18.x]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}

# Wireit cache
- uses: google/wireit@setup-github-actions-caching/v1
- uses: actions/checkout@v4

- uses: pnpm/action-setup@v2.2.2
- uses: pnpm/action-setup@v3
with:
version: 7

- name: Get pnpm store directory
id: pnpm-cache
run: echo "::set-output name=pnpm_cache_dir::$(pnpm store path)"

- name: Setup pnpm cache
uses: actions/cache@v3
- uses: actions/setup-node@v4
with:
path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('./pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store-
cache: 'pnpm'
node-version: 18.x

# Wireit cache
- uses: google/wireit@setup-github-actions-caching/v1

- name: Install dependencies
run: pnpm install
Expand All @@ -52,13 +39,13 @@ jobs:
# - name: Clear all caches
# run: pnpm clean:cache

- name: Build Code and Examples ${{ matrix.node-version }}
- name: Build Code and Examples
run: pnpm run build

# We build in-source files like `examples/one-page/index.html`.
# This check ensures we don't build changes that need committing.
- name: Check generated in-source files
run: git diff --no-ext-diff --quiet --exit-code

- name: Check Code ${{ matrix.node-version }}
- name: Check Code
run: pnpm run check:ci
26 changes: 8 additions & 18 deletions .github/workflows/create-spectacle.yml
Expand Up @@ -24,29 +24,19 @@ jobs:
node-version: [18.x]
create-type: ['tsx', 'onepage']
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}

# Wireit cache
- uses: google/wireit@setup-github-actions-caching/v1
- uses: actions/checkout@v4

- uses: pnpm/action-setup@v2.2.2
- uses: pnpm/action-setup@v3
with:
version: 7

- name: Get pnpm store directory
id: pnpm-cache
run: echo "::set-output name=pnpm_cache_dir::$(pnpm store path)"

- name: Setup pnpm cache
uses: actions/cache@v3
- uses: actions/setup-node@v4
with:
path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('./pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store-
cache: 'pnpm'
node-version: ${{ matrix.node-version }}

# Wireit cache
- uses: google/wireit@setup-github-actions-caching/v1

- name: Install dependencies
run: pnpm install
Expand Down
22 changes: 5 additions & 17 deletions .github/workflows/release.yml
Expand Up @@ -18,30 +18,18 @@ jobs:
pull-requests: write

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Use Node.js
uses: actions/setup-node@v1
with:
node-version: 18.x

- uses: pnpm/action-setup@v2.2.2
- uses: pnpm/action-setup@v3
with:
version: 7

- name: Get pnpm store directory
id: pnpm-cache
run: echo "::set-output name=pnpm_cache_dir::$(pnpm store path)"

- name: Setup pnpm cache
uses: actions/cache@v3
- uses: actions/setup-node@v4
with:
path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store-
cache: 'pnpm'
node-version: 18.x

- name: Install dependencies
run: pnpm install
Expand Down

0 comments on commit 1dd3a89

Please sign in to comment.