-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add one or more certificate and decide which one to use when signing #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e es256 signatures Still need to be generalized to let the user upload personal certifiate and keys and use different type of signature algorithms (RSA and EdDSA)
Next steps: Change requests to dss server based on algorithm used Support also RSA Accept uploaded certificate and refactor the code to move all checks and key manipulation (pkcs8 to raw key fro ecdsa and eddsa) to this step
Add also custom policy file to accpet eddsa signatures
Still nedd to add crypto checks and parsing to key and certificate
… during user upload
also add relation between signature and certificate
During signature phase the user can choose what key-certificate pair to use
…ombEu/signroom into feat/es256_certificate-fix
autosigned certificate is no more created during login, but can be requested on my/certificate page when no certificate are found
github-actions bot
pushed a commit
that referenced
this pull request
May 22, 2024
# [1.2.0](v1.1.0...v1.2.0) (2024-05-22) ### Bug Fixes * show names in the multisignature details page ([#620](#620)) ([4722963](4722963)) * tests auth and run tests on build preview ([#623](#623)) ([2caa7bb](2caa7bb)) ### Features * add one or more certificate and decide which one to use when signing ([#379](#379)) ([e641bc0](e641bc0)) * search users by username also ([#614](#614)) ([eb2196f](eb2196f))
🎉 This PR is included in version 1.2.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.