Add Vue.js Icon #358
Add Vue.js Icon #358
Conversation
mrdrogdrog
force-pushed
the
vuejs
branch
2 times, most recently
from
e2e80ca
to
2a4eb42
Compare
|
|
mrdrogdrog
force-pushed
the
vuejs
branch
7 times, most recently
from
55a3ebe
to
b669a24
Compare
There was a problem hiding this comment.
I had this feeling that something was off about this logo when I first built this pull request.
Now when I was looking at the id, it occurred to me that I could check with Font Awesome. Font Awesome has the vuejs logo where the dark and alpha are inverted ( from this pull request ).
It led me to wonder to check again with the actual Vue.js logo on the project website. And then the Font Awesome version made more sense because the darker color in the logo is in the top of the logo and not along the logo. ( Personally, I prefer the Font Awesome representation ).
But considering this version was accepted by the upstream project, I am not sure how it feels about Font Awesome's representation of the brand. Ping @yyx990803 to get feedback on how the Vue.js project feels about this.
src/icons/icons.yml
Outdated
| @@ -7889,6 +7889,14 @@ icons: | |||
| categories: | |||
| - Brand Icons | |||
|
|
|||
| - name: Vue.js | |||
| id: vue-js | |||
There was a problem hiding this comment.
let us use an id that is requested in the icon request issue, i.e, fa-vue / fa-vuejs. Maybe we could also set up an alias for both.
There was a problem hiding this comment.
Since the name of the lib is "vue.JS" I chose fa-vuejs.
There was a problem hiding this comment.
If you would like, you could add an aliases key for the icon in src/icons/icons.yml, but that is not a requirement though.
There was a problem hiding this comment.
I am going to leave this open for a while to see if we can get direct feedback from the Vue.js project regarding the black and alpha that I raised in my previous review comment ( after comparing with Font Awesome ).
This PR adds the vue.js logo from vuejs/art#12
Fixes #172