Merge pull request #139 from thestr4ng3r/fix-nanohttpd-errors

Prevent WebView's automatic favicon loading
FolioReader · Nov 16, 2017 · 93a1fc2 · 93a1fc2
2 parents eb7e585 + 952804b
commit 93a1fc2
Showing 1 changed file with 31 additions and 0 deletions.
diff --git a/folioreader/src/main/java/com/folioreader/ui/folio/fragment/FolioPageFragment.java b/folioreader/src/main/java/com/folioreader/ui/folio/fragment/FolioPageFragment.java
@@ -1,6 +1,7 @@
 package com.folioreader.ui.folio.fragment;
 
 import android.app.Activity;
+import android.annotation.SuppressLint;
 import android.content.Intent;
 import android.content.res.Configuration;
 import android.graphics.Color;
@@ -21,6 +22,8 @@
 import android.webkit.JavascriptInterface;
 import android.webkit.JsResult;
 import android.webkit.WebChromeClient;
+import android.webkit.WebResourceRequest;
+import android.webkit.WebResourceResponse;
 import android.webkit.WebView;
 import android.webkit.WebViewClient;
 import android.widget.TextView;
@@ -458,6 +461,34 @@ public boolean shouldOverrideUrlLoading(WebView view, String url) {
                 }
                 return true;
             }
+
+
+            // prevent favicon.ico to be loaded automatically
+            @Override
+            public WebResourceResponse shouldInterceptRequest(WebView view, String url) {
+                if(url.toLowerCase().contains("/favicon.ico")) {
+                    try {
+                        return new WebResourceResponse("image/png", null, null);
+                    } catch (Exception e) {
+                        Log.e(TAG, "shouldInterceptRequest failed", e);
+                    }
+                }
+                return null;
+            }
+
+            // prevent favicon.ico to be loaded automatically
+            @Override
+            @SuppressLint("NewApi")
+            public WebResourceResponse shouldInterceptRequest(WebView view, WebResourceRequest request) {
+                if(!request.isForMainFrame() && request.getUrl().getPath().endsWith("/favicon.ico")) {
+                    try {
+                        return new WebResourceResponse("image/png", null, null);
+                    } catch (Exception e) {
+                        Log.e(TAG, "shouldInterceptRequest failed", e);
+                    }
+                }
+                return null;
+            }
         });
 
         mWebview.setWebChromeClient(new WebChromeClient() {