Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Double encoded image urls when using SourceSetViewHelperTrait #1674

Open
akiessling opened this issue Jul 22, 2020 · 1 comment · May be fixed by #1678
Open

Double encoded image urls when using SourceSetViewHelperTrait #1674

akiessling opened this issue Jul 22, 2020 · 1 comment · May be fixed by #1678

Comments

@akiessling
Copy link
Contributor

akiessling commented Jul 22, 2020 •
edited

Related to #693, #1364

I have a FAL file with special chars as input for <v:media.image src="{image.id}" and srcset configuration.

When \FluidTYPO3\Vhs\Traits\SourceSetViewHelperTrait::addSourceSet runs, it already rawurlencodes the url when it calls static::preprocessSourceUri, then preprocessSourceUri runs rawurlencode again.

https://github.com/FluidTYPO3/vhs/blob/development/Classes/Traits/SourceSetViewHelperTrait.php#L52
https://github.com/FluidTYPO3/vhs/blob/development/Classes/ViewHelpers/Media/AbstractMediaViewHelper.php#L61

Result: "Lösungen" becomes "L%25C3%25B6sungen" instead of "L%C3%B6sungen".
I guess the encoding in addSourceSet should be dropped
@akiessling
Copy link
Contributor Author

The problem was already reported in #1512 and got closed, but the issue was not fixed with the referenced change.

@akiessling akiessling linked a pull request Aug 7, 2020 that will close this issue
Open
@liayn liayn mentioned this issue Nov 14, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX] prevent double encoded sourceset urls extrameile/vhs
1 participant
@akiessling