Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Image Srcset wrong url encoding #1887

Open
siwa-pparzer opened this issue Nov 9, 2023 · 1 comment
Open

BUG: Image Srcset wrong url encoding #1887

siwa-pparzer opened this issue Nov 9, 2023 · 1 comment

Comments

@siwa-pparzer
Copy link

https://github.com/FluidTYPO3/vhs/blob/development/Classes/Traits/SourceSetViewHelperTrait.php

images with special characters gets double encoded

src:
/fileadmin/processed/1/c/csm_X90_Zug_%C3%B6ffentlicher_Verkehr_train-0b8e8c69_bb8b2bd812.jpg
generated srcset:
/fileadmin/processed/1/c/csm_X90_Zug_%25C3%25B6ffentlicher_Verkehr_train-0b8e8c69_bb8b2bd812.jpg

the % character is encoded to %25

can be solved via following statement in line 60
$srcsetVariantSrc = str_replace('%25', '%', $srcsetVariantSrc);
@liayn
Copy link
Contributor

liayn commented Nov 14, 2023

duplicate of #1674 ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@liayn @siwa-pparzer