Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add functional tests #875

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

galoppi
Copy link
Contributor

@galoppi galoppi commented Aug 4, 2015

No description provided.

@cedricziel
Copy link
Member

Hi there - Thank you for your contribution!

Please amend the the message of the second commit to have the first word uppercase. Otherwise Travis would decline it in the CGL - checker.

@cedricziel cedricziel changed the title added functional tests [FEATURE] Add functional tests Aug 5, 2015
@NamelessCoder
Copy link
Member

Don't merge - I will take care of this one manually. It has relations to our fluidtypo3-development package and the manipulation of the composer class loader should instead be depended upon in the unit test bootstrapper.

@galoppi
Copy link
Contributor Author

galoppi commented Aug 6, 2015

Yes, I understand.
I think we need another test script in fluidtypo3-development for the functional tests as we need a fully functional typo3 environment and a database with read/write access.
And maybe another approach for the autoloading.
To run the tests we need a script like this:
typo3DatabaseName="dbname" typo3DatabaseUsername="dbuser" typo3DatabasePassword="dbpass" typo3DatabaseHost="dbhost" TYPO3_PATH_WEB="path/to/docroot" ./vendor/bin/phpunit -v --strict -c phpunit-functionaltests.xml.dist --process-isolation --bootstrap vendor/typo3/cms/typo3/sysext/core/Build/FunctionalTestsBootstrap.php Tests/Functional/Service/ContentServiceTest.php

Shall I close this pull request?

@NamelessCoder
Copy link
Member

Please leave open for now - I'll use this and the comments (thanks!) to create functional test runners in fluidtypo3-development. It will be nice to be able to re-run this PR test for that. I may ask for a rebase at some point ;)

@xf- xf- added the on hold label Aug 7, 2015
@NamelessCoder NamelessCoder added this to the Flux 7.3 milestone Aug 8, 2015
@NamelessCoder NamelessCoder removed this from the Flux 7.3 milestone Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants