BUGFIX: Use http request for generating usage urls #235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting usage urls Addresses Flowpack#234
Sebobo
requested changes
Mar 27, 2024
Sebobo
approved these changes
Mar 28, 2024
|
Cool thx. 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #234
What I did
The usage urls now do not include the port when it is not part of the actual domain.
How I did it
Changing the server request for generating usage urls from the server globals to the http request of the active request.
How to verify it
It is working in our local, staging and production setups. When deploying to an environment where neos is running in a docker container and the domain does not include the port, then it should work correctly.