Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SettingWindow's LeftTop Position when first launch #2677

Merged
merged 2 commits into from
May 22, 2024

Conversation

onesounds
Copy link
Contributor

What's The PR

  • Fixed getting stuck in the upper left corner when opening the settings window after the first launch.
  • If Setting Window Position is null, center the screen.

I think I made it this stupid for a reason, but I can't remember.
Needs to be reviewed to see if null is acceptable.

Test Case

When you open the settings window after the first launch with no settings, it is displayed in the center of the screen.

@onesounds onesounds self-assigned this Apr 29, 2024
@onesounds onesounds added the bug Something isn't working label Apr 29, 2024
@VictoriousRaptor
Copy link
Contributor

It's tricky to dealing with the window. Like if I close the settings window when it's minimized, the next time I open it, it stays minimized.

@VictoriousRaptor
Copy link
Contributor

I think I made it this stupid for a reason, but I can't remember.

Maybe because #1368 (comment)

Don't have much time to check but why is it null on first launch?

@onesounds
Copy link
Contributor Author

onesounds commented May 20, 2024

I think I made it this stupid for a reason, but I can't remember.

Maybe because #1368 (comment)

Don't have much time to check but why is it null on first launch?

image
(I didn't know too so I looked it up)
The settings window doesn't have a default value on initial launch, so it seems to have done so.

+) ?? That's some weird code. Why did I write that? (I tested it and it works)

@onesounds
Copy link
Contributor Author

Fixed. (I think I wrote the code while drunk.)

@jjw24 jjw24 merged commit a68b180 into Flow-Launcher:dev May 22, 2024
3 checks passed
@jjw24 jjw24 added this to the 1.19.0 milestone May 22, 2024
@onesounds onesounds deleted the 240430WindowPosition branch May 22, 2024 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants