-
-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to Velopack & Github Action #2616
base: dev
Are you sure you want to change the base?
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Looks like something's broken but I don't have any idea. |
Previously the vpk installation takes 30s, so I add a cache, but weird, it should at least run the install🤔 |
@JohnTheGr8 maybe let's get this in first. I think handling the conflict in .net 8 will be easier. |
@@ -49,7 +49,8 @@ | |||
|
|||
<ItemGroup> | |||
<PackageReference Include="Moq" Version="4.18.4" /> | |||
<PackageReference Include="nunit" Version="3.14.0" /> | |||
<PackageReference Include="NUnit" Version="4.1.0" /> | |||
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="17.8.0" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
double reference to Microsoft.NET.Test.Sdk
here (mistake during conflict resolve, I assume)
#cache: | ||
# - '%USERPROFILE%\.nuget\packages -> **.sln, **.csproj' # preserve nuget folder (packages) unless the solution or projects change | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was this change meant to be temporary? Also, shouldn't we be caching the dotnet tools folder here, as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think cache is not improving the building time....it seems to take very long time to unzip the cache...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, couple of things:
- Toggling out of portable via settings doesnt seem to do anything except creating the UserData folder in roaming. Expecting to move portable UserData to roaming, plus start menu and uninstall program entries created.
- Toggling into portable mode does not remove the uninstall entry in 'Uninstall Program' in control panel, nor does it remove the entry from start menu.
- Can we please make the parent folder name FlowLauncher not flowlauncher, same goes for the UserData folder name in roaming.
- Can we please change the publisher in uninstall program to 'Flow Launcher Team' not 'FlowLauncher'.
Actually, on the second thought, do we still want to preserve the ability to change from non-portable to portable? I think if user want to use portable they would download the portable version on first use, rather than converting the installed version to portable. I think this is kindly a historical reason for us to have these feature... |
Velopack (https://velopack.io/) is the successor of Cloud.Squirrel (https://github.com/clowd/Clowd.Squirrel)
Several change in this pr
%LocalAppData%
as velopack will pack the portable version for us, which doesn't allow us to modify (easily) to insert a custom folder.win-x64-prerelease
channel, while the main repo will havewin-x64-stable
channel. https://docs.velopack.io/packaging/channelsTODO:
Tested:
UserData
folderFuther Consideration:
vpk pack
Note: Maybe we want to squash so revert is easier?