-
-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flow Launcher Theme Selector plugin #2448
base: dev
Are you sure you want to change the base?
Flow Launcher Theme Selector plugin #2448
Conversation
Great idea. I think this plugin would be best served by publishing to the Store. We can have a look at exposing the needed methods via the API. |
I feel like we can allow this plugin to be built in. Thememanager is pretty internal. |
Well yes and no, it's directly referencing the core project, ideal design is to have even the default plugins as self contained. |
Some of our internal stuff uses the plugin interface for receiving query, which I think is a pretty good idea. I am not sure whether exposing everything to the interface is a very good idea. PublicAPI sometimes can be the curse as we may want to maintain backward compatibility. |
Well I think at least this functionality is a good one to enable plugins to use. Remember the more plugins we pack the more we need to maintain and the bigger the size eventually get. More ideal to encourage plugin development. |
well a plugin only takes 400k size...which should be pretty neglectable. and this feature seems to be good to built in. |
@Odotocodot isn't you also need to add the plugin folder to the solution? |
@check-spelling-bot Report🔴 Please reviewSee the 📂 files view, the 📜action log, or 📝 job summary for details.Unrecognized words (4)flowtheme To accept these unrecognized words as correct, you could run the following commands... in a clone of the git@github.com:Odotocodot/Flow.Launcher.git repository curl -s -S -L 'https://raw.githubusercontent.com/check-spelling/check-spelling/prerelease/apply.pl' |
perl - 'https://github.com/Flow-Launcher/Flow.Launcher/actions/runs/8510417023/attempts/1'
Warnings (1)See the 📂 files view, the 📜action log, or 📝 job summary for details.
See ℹ️ Event descriptions for more information. If the flagged items are 🤯 false positivesIf items relate to a ...
|
What about putting this functionality in the Sys plugin since it has flow related functionalities like open log file and reload data etc. |
Sorry ive been busy with uni!
So move to be inside the sys plugin?
Im not sure its needed? or im confused... its be a while |
I would say ideally exposing the methods via the plugin API would be the best so people can build plugin around it, but this change can be complicated, so putting it in the Sys plugin is the next best option. |
A plugin to quickly change the current Flow Launcher theme.
If someone has a better suggestion for the default action keyword rather than
flowtheme
, would love to hear it. Was a bit apprehensive in using theme 🤷♂️ .