BadFunctions/NoEvals: add unit tests + minor fix #73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrfnl
force-pushed
the
feature/noevals-add-unit-tests
branch
from
ea2d7bc
to
171dc78
Compare
`eval()` is a language construct, not a function. Ref: https://www.php.net/manual/en/function.eval.php
`$tokens` is not used, so no need to declare it.
jrfnl
force-pushed
the
feature/noevals-add-unit-tests
branch
from
171dc78
to
0c57997
Compare
|
Anything I can do to move this PR forward ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #57, follow up on #70, this PR adds unit tests for the
Security.BadFunctions.NoEvalssniff.Commit Summary
BadFunctions/NoEvals: add unit tests
BadFunctions/NoEvals: error message precision
eval()is a language construct, not a function.Ref: https://www.php.net/manual/en/function.eval.php
BadFunctions/NoEvals: remove redundant function call
$tokensis not used, so no need to declare it.