FlxEmitter problems with non-square sprites

[FlixelCommunityBot]

Issue #222 by: cyberpro4

I've got some problems with FlxEmitter rotation: I've used some non-square image as particles but during rotation happen two things:

First, the particles was cutted: this was caused by loadRotatedGraphic in makeParticles function: the default AutoBuffer parameter is set to false and there's no way to force it to true via makeParticles() func.

Second, since my bitmap is trasparent I've notice an white solid fill in final rotation bitmap: in FlxSprite::loadRotatedGraphic() the brush variable is constructed with default fill color 0xFFFFFFFF ( solid white ).

At now, I've force these values, but I think this "bug" needs to be fixed.

[Dovyski]

I would like to suggest moving this issue to "Future release" milestone. It can be marked as a bug, but I think it's the consequence of a poor FlxEmitter customization API.

FlxEmitter should receive some overhauling, which could include a more flexible API for customization. Axel has some interesting features, such as "named emitters". That's quite useful:

var effect:AxParticleEffect = new AxParticleEffect("collect-coin", Resource.PARTICLE, 10);

effect.xVelocity = new AxRange(-70, 70);
effect.yVelocity = new AxRange(-70, 70);
effect.lifetime = new AxRange(0.5, 1.5);
effect.amount = 100;
effect.blend = AxBlendMode.PARTICLE;
effect.color(new AxColor(0.3, 0.3, 0.3), new AxColor(1, 1, 1), new AxColor(0.3, 0.3, 0.3), new AxColor(1, 1, 1));

(...)

AxParticleSystem.emit("collect-coin", gem.center.x, gem.center.y);

We could borrow some ideas from there.

[Gama11]

@Dovyski "Named emitters" (similar to the way animations work in flixel) seems like an awesome feature! I've always been annoyed by the way emitters work, it's kinda difficult and takes a lot of time to come up with the "right" / good values for it to look good. FlxEmitters could come with a set few pre-made / pre-defined emitters.

I've started doing a similar thing by creating a new class for my emitters and speficying the values in the constructor. This solution, however, would be a lot more convenient.

[Dovyski]

I've started doing a similar thing by creating a new class for my emitters and speficying the values in the constructor. This solution, however, would be a lot more convenient.

I was doing the same, that's why I suggested the named emitters :)

[Dovyski]

I'm pushing this issue up to the "Future release" milestone since the changes required to fix it demand new features (better API for FlxEmitter).