Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
small doc improvements from user testing #97
small doc improvements from user testing #97
Changes from 9 commits
1c395d9
077d7aa
82e44ec
e4b8189
6816967
d4a3111
c5923ae
471b47a
faa5996
66e116b
2c6d543
945fbbb
12842c1
a365295
09af1e6
910f235
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Flix6x The use of
current_app
"outside" the function like this is not possible, as there is no application context at that point. I learned that from all our tests falling, as importing this file breaks.We have to find a different way. If, for play mode,
infer_missing
is always True for horizons ad False for prior, maybe it could go into the respective validators.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for finding out. I'll move the logic back into the validators, and devise of some other way of letting v1.x and v2 endpoints choose to use this logic. Alas,
infer_missing
is not always True for horizons in play mode. Specifically, it is False for the postPrognosis endpoint v1.x, even in play mode. I could make the boolean optional, and set the default to None implying inference, so endpoints can be explicit or let the validator choose a default depending on server mode.For the horizon validator:
infer_missing=False
infer_missing=True
infer_missing=False
infer_missing=None
-> True if in play, False otherwiseFor the prior validator:
infer_missing=None
-> False if in play, True otherwiseSo to be clear, the differences between v1.x and v2 are that: