Try re-adding CLI tests on Github Actions #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
2 tasks
Closed
Signed-off-by: Nicolas Höning <nicolas@seita.nl>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Trying if we can unskip some CLI tests here in Github Actions. (we had to skip them a while ago as they led to weird errors, but only in GA, not locally).
The approach this time is the only run them on a fresh database.
It would be good to add them here, as our coverage is underreported. But devs run them locally.
How to test
We can only test by pushing and seeing the results of GA.
State
I see these tests passing now, but there is something going wrong with routing when CLI tests are in the mix on GA...
The UI tests see something else than expected on the login page, and the error response tests see 302 status codes instead of the error codes they expected. This does not happen locally.
Re-skipping the CLI tests on GA will remove that problem.
Too weird to spend more time with this for now ...