Add SQLAlchemy type annotations #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Flix6x
added
documentation
|
So this is helping you with your work in your editor? Or with flake8? I don't know if I have any problems like this. |
|
Helping me with database migration in my editor. |
|
That reminds me: PR #54 had to move the migrations directory. Will be interesting to see how the merge conflict will look like. |
nhoening
approved these changes
Mar 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: missing type annotations for flask-sqlalchemy objects.
Suggested fix: Type annotating
flask_sqlalchemy.SQLAlchemyobjects assqlalchemyobjects was a suggested work-around, from pallets-eco/flask-sqlalchemy#867.