Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Entity address scheme improvements #66

Closed
wants to merge 62 commits into from
Closed

Entity address scheme improvements #66

wants to merge 62 commits into from

Conversation

create-issue-branch[bot]
Copy link
Contributor

closes #6

Flix6x and others added 30 commits March 19, 2021 15:28
@Flix6x
Create draft PR for #6
d9b5fe3
@Flix6x
Add cli function to dump database
cc197c6
@Flix6x
Add cli function to restore database
5f69865
@Flix6x
Add SQLAlchemy type annotations
8e6bf3d
@Flix6x
Use database name in filename of dump
89f7d0c
@Flix6x
Mention the generated filename
bd502ee
@Flix6x
Mention resetting before restoring
79f7ad8
@Flix6x
Changelog entry
f53e5ac
@Flix6x
Update data/Readme.md
6cb2681
@Flix6x
Merge branch 'db-dev-utils' into Unique_generic_sensor_ids
53b97eb
@Flix6x
Ensure unique ids across all sensors
5990866
@Flix6x
Merge branch 'main' into Unique_generic_sensor_ids
b63c0d6
@Flix6x
Get rid of FutureWarning.
4419ab6
@Flix6x
Allow prior field in postPriceDataRequest.
523d1e9
@Flix6x
Clean up inferred belief times using the new prior field for POST req…
19e213f 
…uests.
@Flix6x
Update documentation.
d6b30aa
@Flix6x
Update docstring of postPriceData.
095a86e
@Flix6x
Deprecate horizon inference for API versions 1.x.
3237090
@Flix6x
Typo.
c737abd
@Flix6x
Add missing documentation on REST endpoints for users.
9025ed6 
Change GET to PATCH in service listing for the password-reset endpoint.
@Flix6x
Reformulate sentences.
b485a20
@Flix6x
Refactor test message for posting price data.
728b911 
Finish its docstring parameters.
@Flix6x
Add todo.
555b152
@Flix6x
Black.
916b43e
@Flix6x
Improve error message for ChartRequestSchema param show_individual_tr…
1c034ba 
…aces_for.
@Flix6x
Refactor already triplicate code.
dfb1950
@Flix6x
Refactor code interpreting horizon and prior.
559a098
@Flix6x
Allow prior field in postWeatherDataRequest.
98caebe
@Flix6x
Move postPrognosis endpoint forward to later versions
4ab21ec
@Flix6x
Consistent coding
5b5cd4f
Flix6x and others added 20 commits March 23, 2021 15:45
@Flix6x
Simplify determine_belief_horizons
da8cf1b
@Flix6x
Rename and clarify
92dd94e
@Flix6x
Clarify rule for resolving case in which horizon and prior are both set
1abbb59
@Flix6x
Refactor determine_belief_timing
3b82597
@Flix6x
Update date in change_log.rst
f53ea11
@Flix6x
Entries in main changelog.rst
437aee0
@Flix6x
Create draft PR for #6
88c990e
@Flix6x
Rename entity type for weather sensors
0a336d8
@Flix6x
Update domain registration year in docstring
e454fb6
@Flix6x
Fix test given new id
8af502c
@Flix6x
Build and parse sensor entity addresses
963a086
@Flix6x
Fix pass-through of error response
7f5ac6f
@Flix6x
Add entity address properties to Market and WeatherSensor
849308e
@Flix6x
Make test util function more flexible
783a176
@Flix6x
Add marshmallow schema for sensors
b1831cd
@Flix6x
Improve test legibility
fd6c0d0
@Flix6x
Move setup of test WeatherSensors to higher conftest.py
c9b2a5d
@Flix6x
Better regex for date specification
822c25b
@Flix6x
Test marshmallow schema for sensors
0968f0d
@Flix6x
Merge branch 'issue-6-Entity_address_scheme_improvements' of github.c…
1d01c10 
…om:SeitaBV/flexmeasures into issue-6-Entity_address_scheme_improvements
@Flix6x Flix6x self-assigned this Mar 23, 2021
@Flix6x Flix6x added the API label Mar 23, 2021
@Flix6x Flix6x changed the base branch from main to Unique_generic_sensor_ids March 23, 2021 19:53
@Flix6x Flix6x changed the base branch from Unique_generic_sensor_ids to main March 25, 2021 15:51
@nhoening
Copy link
Contributor

Two general comments:

  1. Something seems to have gone wrong when changing the base branch. There are 62 commits in here. Would it be possible to start a new PR with only the relevant commits?
  2. Reminder to update the documentation of EA addressing (e.g. in api/introduction)

@nhoening nhoening mentioned this pull request Apr 1, 2021
Merged
@Flix6x Flix6x closed this Apr 2, 2021
@Flix6x Flix6x deleted the issue-6-Entity_address_scheme_improvements branch April 2, 2021 09:08
@Flix6x
Copy link
Contributor

Flix6x commented Apr 2, 2021

Moved to #81

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Flix6x Flix6x

Labels
API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Entity address scheme improvements
2 participants
@nhoening @Flix6x