Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

552 playback button stopped working #553

Merged
merged 3 commits into from Dec 12, 2022
Merged

552 playback button stopped working #553

merged 3 commits into from Dec 12, 2022

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Dec 12, 2022

Closes #552 by fixing pre-release bug introduced in #533 (no changelog entry).

@Flix6x
Move setup of abort controller to before its first use
552c491 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Calendar selection is no longer trigger upon page load, so initialize…
4bc83ac 
… replay div with "stopped" class

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Initialize the time window selection from session data, if available
d4606c2 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x added bug Something isn't working UI labels Dec 12, 2022
@Flix6x Flix6x added this to the 0.12.0 milestone Dec 12, 2022
@Flix6x Flix6x requested a review from nhoening December 12, 2022 10:36
@Flix6x Flix6x self-assigned this Dec 12, 2022
@Flix6x Flix6x linked an issue Dec 12, 2022 that may be closed by this pull request
Playback button stopped working #552
Closed
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 3674930377

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 64.946%
Totals Coverage Status
Change from base Build 3664805850: 0.0%
Covered Lines: 6643
Relevant Lines: 9592
💛 - Coveralls

nhoening
nhoening approved these changes Dec 12, 2022
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Flix6x Flix6x merged commit 6532cc1 into main Dec 12, 2022
@Flix6x Flix6x deleted the 552-playback-button-stopped-working branch December 12, 2022 19:40
@Flix6x Flix6x restored the 552-playback-button-stopped-working branch December 20, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@Flix6x Flix6x

Labels
bug Something isn't working UI
Projects
None yet
Milestone
0.12.0
Development

Successfully merging this pull request may close these issues.

Playback button stopped working
3 participants
@Flix6x @coveralls @nhoening