New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 502 visually distinguish forecasts from measurements #503
Merged
Flix6x
merged 14 commits into
main
from
issue-502_Visually_distinguish_forecasts_from_measurements
Oct 13, 2022
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
0047179
Add vega formatter for timedeltas
Flix6x b1b7142
Add JSON column with belief horizons
Flix6x 8d0d480
Separate lines for measurements (solid) and forecasts (dashed)
Flix6x 2724ac0
Add human-readable horizon to tooltip
Flix6x 473a0ba
Changelog entry
Flix6x dbdb885
flake8
Flix6x 50f23c3
Support formatting negative timedeltas
Flix6x e1c4cef
clarify the meaning of timedeltaFormat parameters
Flix6x 144ae0e
Speed up asset chart loading by not looking up the timerange of senso…
Flix6x 0ededc9
Use bin instead of extra layers with filters, so a legend can be shown
Flix6x 48c0299
Merge remote-tracking branch 'origin/main' into issue-502_Visually_di…
Flix6x c6fff67
black, flake8
Flix6x 15a7e64
Remove dev code
Flix6x ab42e39
flake8
Flix6x File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we document here what I had to find out by myself?
params[0] is a D3 format identifier (.e.g "d" for days)
params[1] is a multiplier which decides from how many X on we format as Y (e.g. <=3 days means we format as "hours")
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, d stands for decimal notation, rounded to integer. It's a d3-format rather than a d3-time-format. I'm expanding the inline documentation.