New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Get resampled data #458
Merged
Merged
Get resampled data #458
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
57a8823
Allow GETting resampled data
Flix6x 1b55a74
Add docstring comment to schema
Flix6x c63315e
Add missing type annotation
Flix6x 8dabfaf
Validate resolution field
Flix6x 4f96f39
Add resolution field to schema
Flix6x e8477db
Field is optional
Flix6x 11e8bc3
Use resampled resolution when reindexing
Flix6x 58ebc13
Add test for deserializing the resolution field
Flix6x 3b83d50
API changelog entry
Flix6x 0e07799
Add resolution field to example
Flix6x 655f5d9
Changelog entry
Flix6x d14b4c3
Improve docstring
Flix6x File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
30 changes: 30 additions & 0 deletions
30
flexmeasures/api/common/schemas/tests/test_sensor_data_schema.py
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So here we're testing that timely beliefs changes the representation of the field.
Is there no need to use some data to test resolution adaptations? Do we already test that someplace else (testing the
search
function?I noticed that in the API level we are not testing GETting sensor data, just posting...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not timely-beliefs. This checks whether the given marshmallow schema in FlexMeasures parses these particular ISO durations as python timedeltas. I'd love to extend this with some nominal durations, but unfortunately timely-beliefs only works with absolute durations for now. I'll add this info to the test.
Low level tests for resampling data should happen in timely-beliefs imo.