do not fail the sensor attribute when building an entity address #457
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #456
Do warn about failure to build entity addresses, however.
This particular failure to build them has to do with the domain FlexMeasures runs on, which becomes part of the address.
When FlexMeasuresa starts, we don't know the domain ― currently, we find out where we run on request information.
Thus, warning about this failure in the terminal when FlexMeasures starts seems difficult. The failure becomes visual when the asset page is visited ("no entity address available"), so it will come up.
It will also come up if someone gets sensor data programmatically, via the API's GET /sensors endpoint, which also includes the entity address.