Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 273 add roundtrip efficiency to scheduler #291

Merged
merged 64 commits into from Jan 3, 2022
Merged

Issue 273 add roundtrip efficiency to scheduler #291

merged 64 commits into from Jan 3, 2022

Commits on Dec 26, 2021

  1. Query TimedBelief rather than Power in api v1.3 tests 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 26, 2021
    Copy the full SHA
    8f4b724 View commit details
    Browse the repository at this point in the history

  2. Query TimedBelief rather than Power in api v1.3 implementations 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 26, 2021
    Copy the full SHA
    61e2fd8 View commit details
    Browse the repository at this point in the history

  3. Query TimedBelief rather than Power in user services tests 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 26, 2021
    Copy the full SHA
    07a8059 View commit details
    Browse the repository at this point in the history

  4. Query TimedBelief rather than Power in query tests 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 26, 2021
    Copy the full SHA
    0b94664 View commit details
    Browse the repository at this point in the history

  5. Query TimedBelief rather than Power in forecasting tests 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 26, 2021
    Copy the full SHA
    f3504bd View commit details
    Browse the repository at this point in the history

  6. Query TimedBelief rather than Power in scheduling tests 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 26, 2021
    Copy the full SHA
    d196847 View commit details
    Browse the repository at this point in the history

  7. Query TimedBelief rather than Power in api v1 tests 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 26, 2021
    Copy the full SHA
    9a7f32e View commit details
    Browse the repository at this point in the history

  8. Simplify data deletion, like, by a lot 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 26, 2021
    Copy the full SHA
    0651806 View commit details
    Browse the repository at this point in the history

  9. Count ex-ante TimedBeliefs after populating time series forecasts 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 26, 2021
    Copy the full SHA
    923406e View commit details
    Browse the repository at this point in the history

  10. Query TimedBelief rather than Price in api v1_1 tests 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 26, 2021
    Copy the full SHA
    acfbc8a View commit details
    Browse the repository at this point in the history

  11. Query TimedBelief rather than Power/Price/Weather in Resource.load_se… 

    …nsor_data

Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 26, 2021
    Copy the full SHA
    d892995 View commit details
    Browse the repository at this point in the history

  12. Query TimedBelief rather than Power/Price/Weather in api v2.0 tests 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 26, 2021
    Copy the full SHA
    70bed39 View commit details
    Browse the repository at this point in the history

  13. Refactor: simplify duplicate query construction 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 26, 2021
    Copy the full SHA
    8289bba View commit details
    Browse the repository at this point in the history

  14. Add custom join target to get rid of SA warning 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 26, 2021
    Copy the full SHA
    78ab21d View commit details
    Browse the repository at this point in the history

  15. Filter criteria should work for both TimedBeliefs and TimedValues 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 26, 2021
    Copy the full SHA
    109d547 View commit details
    Browse the repository at this point in the history

  16. Clarify docstring 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 26, 2021
    Copy the full SHA
    ff45672 View commit details
    Browse the repository at this point in the history

  17. Query TimedBelief rather than Power in api v1 implementations 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 26, 2021
    Copy the full SHA
    47ed019 View commit details
    Browse the repository at this point in the history

  18. Schedules should contain one deterministic belief per event 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 26, 2021
    Copy the full SHA
    4eb0856 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2021

  1. Fix type annotation 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 27, 2021
    Copy the full SHA
    45f5bb5 View commit details
    Browse the repository at this point in the history

  2. flake8 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 27, 2021
    Copy the full SHA
    28041c6 View commit details
    Browse the repository at this point in the history

  3. Query TimedBelief rather than Price/Weather for analytics 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 27, 2021
    Copy the full SHA
    613f591 View commit details
    Browse the repository at this point in the history

  4. Query deterministic TimedBelief rather than Price for planning queries 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 27, 2021
    Copy the full SHA
    3ca9a8f View commit details
    Browse the repository at this point in the history

  5. Forecast TimedBelief rather than Power/Price/Weather 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 27, 2021
    Copy the full SHA
    27dc9ef View commit details
    Browse the repository at this point in the history

  6. Schedule TimedBelief rather than Power 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 27, 2021
    Copy the full SHA
    66e6da0 View commit details
    Browse the repository at this point in the history

  7. Apparently, to initialize a TimedBelief is to save a TimedBelief, too 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 27, 2021
    Copy the full SHA
    fb58ec7 View commit details
    Browse the repository at this point in the history

  8. Create TimedBelief rather than Power/Price/Weather in data generation… 

    … script

Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 27, 2021
    Copy the full SHA
    b15a445 View commit details
    Browse the repository at this point in the history

  9. Bump timely-beliefs dependency 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 27, 2021
    Copy the full SHA
    6af5027 View commit details
    Browse the repository at this point in the history

  10. Fix latest state query 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 27, 2021
    Copy the full SHA
    809c6d0 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2021

  1. Revert "Apparently, to initialize a TimedBelief is to save a TimedBel… 

    …ief, too"

This reverts commit fb58ec7.
    @Flix6x
    Flix6x committed Dec 28, 2021
    Copy the full SHA
    4c94a97 View commit details
    Browse the repository at this point in the history

  2. Prevent saving TimedBelief to session upon updating Sensor or Source 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 28, 2021
    Copy the full SHA
    9f618ee View commit details
    Browse the repository at this point in the history

  3. Create only TimedBeliefs in conftests 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 28, 2021
    Copy the full SHA
    fb5d311 View commit details
    Browse the repository at this point in the history

  4. Use session.add_all calls instead of session.bulk_save_objects or ind… 

    …ividual session.add calls

Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 28, 2021
    Copy the full SHA
    23e42a1 View commit details
    Browse the repository at this point in the history

  5. API directly creates TimedBeliefs 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 28, 2021
    Copy the full SHA
    b942fa0 View commit details
    Browse the repository at this point in the history

  6. CLI uses TimedBeliefs only 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 28, 2021
    Copy the full SHA
    24a785e View commit details
    Browse the repository at this point in the history

  7. Data scripts use TimedBeliefs only 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 28, 2021
    Copy the full SHA
    d5f181d View commit details
    Browse the repository at this point in the history

  8. One more conftest switched to creating TimedBeliefs instead of Weathe… 

    …r objects

Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 28, 2021
    Copy the full SHA
    314f700 View commit details
    Browse the repository at this point in the history

Commits on Dec 30, 2021

  1. Expand docstring note on forbidden replacements 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 30, 2021
    Copy the full SHA
    9ffd449 View commit details
    Browse the repository at this point in the history

  2. Clarify docstring note on saving changed beliefs only 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 30, 2021
    Copy the full SHA
    9b1fb22 View commit details
    Browse the repository at this point in the history

  3. Remove redundant flush 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 30, 2021
    Copy the full SHA
    229e230 View commit details
    Browse the repository at this point in the history

  4. Catch forbidden belief replacements with more specific exception 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 30, 2021
    Copy the full SHA
    fa563f3 View commit details
    Browse the repository at this point in the history

  5. Rename variable 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 30, 2021
    Copy the full SHA
    95ccb15 View commit details
    Browse the repository at this point in the history

  6. One transaction per request 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 30, 2021
    Copy the full SHA
    57875e4 View commit details
    Browse the repository at this point in the history

  7. Only enqueue forecasting jobs upon successfully saving new data 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 30, 2021
    Copy the full SHA
    c514cb5 View commit details
    Browse the repository at this point in the history

  8. Flush instead of commit 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 30, 2021
    Copy the full SHA
    dda69a9 View commit details
    Browse the repository at this point in the history

  9. Expand test for forbidden data replacement 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 30, 2021
    Copy the full SHA
    2d5f721 View commit details
    Browse the repository at this point in the history

  10. Simplify play mode excemption for replacing beliefs 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 30, 2021
    Copy the full SHA
    cd6b8c6 View commit details
    Browse the repository at this point in the history

  11. Add note about potential session rollback 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 30, 2021
    Copy the full SHA
    d7c0512 View commit details
    Browse the repository at this point in the history

  12. Typo 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 30, 2021
    Copy the full SHA
    bb7171a View commit details
    Browse the repository at this point in the history

  13. Move UniqueViolation catching logic to error handler 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 30, 2021
    Copy the full SHA
    fec17b7 View commit details
    Browse the repository at this point in the history

  14. flake8 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Dec 30, 2021
    Copy the full SHA
    31ec00a View commit details
    Browse the repository at this point in the history

Commits on Jan 1, 2022

  1. Rewrite solver to deal with asymmetry in up and down commitment prices 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Jan 1, 2022
    Copy the full SHA
    a2fc26b View commit details
    Browse the repository at this point in the history

  2. Add optional roundtrip_efficiency field to UDI events, and use it to … 

    …scale prices

Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Jan 1, 2022
    Copy the full SHA
    9f3ab24 View commit details
    Browse the repository at this point in the history

  3. Add test cases for various round-trip efficiencies 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Jan 1, 2022
    Copy the full SHA
    4f9f5c8 View commit details
    Browse the repository at this point in the history

  4. Add changelog entries 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Jan 1, 2022
    Copy the full SHA
    32034eb View commit details
    Browse the repository at this point in the history

  5. Add documentation for the new API field 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Jan 1, 2022
    Copy the full SHA
    ae0c9cf View commit details
    Browse the repository at this point in the history

  6. Grammar corrections 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Jan 1, 2022
    Copy the full SHA
    981ff8f View commit details
    Browse the repository at this point in the history

  7. Fix return value for empty EMS 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Jan 1, 2022
    Copy the full SHA
    48d98e7 View commit details
    Browse the repository at this point in the history

  8. Allow efficiencies per device for multi-device EMS, by stopping the a… 

    …pplication of round-trip efficiency as price scalars and modeling device flows in more detail

Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Jan 1, 2022
    Copy the full SHA
    6c86207 View commit details
    Browse the repository at this point in the history

  9. Relax tests using some tolerance 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Jan 1, 2022
    Copy the full SHA
    3c9d6bf View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2022

  1. Fix mistake 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Jan 2, 2022
    Copy the full SHA
    ba12570 View commit details
    Browse the repository at this point in the history

  2. Add test docstring 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Jan 2, 2022
    Copy the full SHA
    b3cea6f View commit details
    Browse the repository at this point in the history

  3. Check round-trip efficiency for acceptable range 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Jan 2, 2022
    Copy the full SHA
    a95936f View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2022

  1. Expand docstring 

    Signed-off-by: F.N. Claessen <felix@seita.nl>
    @Flix6x
    Flix6x committed Jan 3, 2022
    Copy the full SHA
    527d926 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/project-9' into Issue-273_Add_ro… 

    …undtrip_efficiency_to_scheduler

Signed-off-by: F.N. Claessen <felix@seita.nl>

# Conflicts:
#	flexmeasures/api/__init__.py
#	flexmeasures/api/dev/tests/test_sensor_data.py
#	flexmeasures/data/models/time_series.py
#	flexmeasures/data/scripts/data_gen.py
#	flexmeasures/data/tests/test_queries.py
#	flexmeasures/data/utils.py
    @Flix6x
    Flix6x committed Jan 3, 2022
    Copy the full SHA
    28109ea View commit details
    Browse the repository at this point in the history