Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sub issue 284b query timed belief rather than power/price/weather #287

Merged
merged 33 commits into from Dec 29, 2021
Merged

Sub issue 284b query timed belief rather than power/price/weather #287

merged 33 commits into from Dec 29, 2021

Conversation

Flix6x
Copy link
Contributor

@Flix6x Flix6x commented Dec 26, 2021 •
edited

Second sub-issue of #284:

  • Query TimedBelief rather than Power/Price/Weather

This PR moves time series queries to the new data model, and also has forecasting and scheduling jobs directly create TimedBeliefs.

@nhoening If you need me to (for the review), I could still try to split the work into separate PRs. Currently, the last 4 commits deal with creating TimedBeliefs, while the rest deals with querying them.

Requires timely-beliefs>=1.9.0.

@Flix6x
Query TimedBelief rather than Power in api v1.3 tests
8f4b724 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Query TimedBelief rather than Power in api v1.3 implementations
61e2fd8 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Query TimedBelief rather than Power in user services tests
07a8059 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Query TimedBelief rather than Power in query tests
0b94664 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Query TimedBelief rather than Power in forecasting tests
f3504bd 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Query TimedBelief rather than Power in scheduling tests
d196847 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Query TimedBelief rather than Power in api v1 tests
9a7f32e 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Simplify data deletion, like, by a lot
0651806 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Count ex-ante TimedBeliefs after populating time series forecasts
923406e 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Query TimedBelief rather than Price in api v1_1 tests
acfbc8a 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Query TimedBelief rather than Power/Price/Weather in Resource.load_se…
d892995 
…nsor_data

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Query TimedBelief rather than Power/Price/Weather in api v2.0 tests
70bed39 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Refactor: simplify duplicate query construction
8289bba 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Add custom join target to get rid of SA warning
78ab21d 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Filter criteria should work for both TimedBeliefs and TimedValues
109d547 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Clarify docstring
ff45672 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Query TimedBelief rather than Power in api v1 implementations
47ed019 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Schedules should contain one deterministic belief per event
4eb0856 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x self-assigned this Dec 26, 2021
@Flix6x
Fix type annotation
45f5bb5 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
flake8
28041c6 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Query TimedBelief rather than Price/Weather for analytics
613f591 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Query deterministic TimedBelief rather than Price for planning queries
3ca9a8f 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Forecast TimedBelief rather than Power/Price/Weather
27dc9ef 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Schedule TimedBelief rather than Power
66e6da0 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Apparently, to initialize a TimedBelief is to save a TimedBelief, too
fb58ec7 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Create TimedBelief rather than Power/Price/Weather in data generation…
b15a445 
… script

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Bump timely-beliefs dependency
6af5027 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x marked this pull request as ready for review December 27, 2021 13:53
@Flix6x Flix6x requested a review from nhoening December 27, 2021 13:54
@Flix6x
Fix latest state query
809c6d0 
Signed-off-by: F.N. Claessen <felix@seita.nl>
nhoening
nhoening requested changes Dec 28, 2021
View reviewed changes
Copy link
Contributor

@nhoening nhoening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very satisfying to read! I believe my comments are mostly about documentation and more deprecation. Also one actual error I believe, in a test function name.

flexmeasures/data/models/forecasting/model_spec_factory.py Show resolved Hide resolved
flexmeasures/data/models/time_series.py Outdated Show resolved Hide resolved
flexmeasures/data/scripts/data_gen.py Outdated Show resolved Hide resolved
flexmeasures/data/tests/test_queries.py Outdated Show resolved Hide resolved
flexmeasures/data/tests/test_queries.py Outdated Show resolved Hide resolved
@Flix6x
Expand inline note
f89eb88 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Refactor: simplify block in data_gen.py
20e4c3a 
Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x
Add back test and fix it by selecting only the most recent beliefs wh…
115a610 
…en resampling, and by solving a bug in a deprecated optional argument. Also, remove redundant index conversions in test, and move one conversion closer to where it is needed

Signed-off-by: F.N. Claessen <felix@seita.nl>
@Flix6x Flix6x requested a review from nhoening December 29, 2021 09:45
@Flix6x Flix6x merged commit f651eea into Issue-284_Move_sensor_data_from_Power/Price/Weather_to_TimedBelief Dec 29, 2021
@Flix6x Flix6x deleted the Sub-issue-284b_Query_TimedBelief_rather_than_Power/Price/Weather branch December 29, 2021 20:03
@Flix6x Flix6x added this to the 0.8.0 milestone Jan 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhoening nhoening nhoening approved these changes

Assignees

@Flix6x Flix6x

Labels
None yet
Projects
None yet
Milestone
0.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Flix6x @nhoening