New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document how plugins can add a custom favicon #152
Conversation
I tested this locally with our current customer's plugin. Before merging, lets' wait for #151 to land, so we can check if the generated documentation looks nice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks clear to me.
Actually, I may have run into a problem: I noticed that by overriding the static folder, any plugin logic that uses content from the original flexmeasures static folder |
Good catch, this needs a little tinkering with an own static path and/or url for the blueprint: https://www.siparker.net/python/how-to-use-blueprint-static-folders-correctly-in-python-flask/ |
If we leave this one line out (see 61a0b08), both static folders (of the app and of the plugin) seem to be served on the app's static url path. Then there is no need anymore to copy over static content from the app to the plugin. |
So you checked that the favicon still is served?
The documentation below should then talk about "path", not "paths".
Am 19. Juli 2021 14:38:46 MESZ schrieb Felix Claessen ***@***.***>:
…If we leave this one line out (see 61a0b08), both static folders (of
the app and of the plugin) seem to be served on the app's static url
path. Then there is no need anymore to copy over static content from
the app to the plugin.
--
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
#152 (comment)
-- Gesendet von /e/ Mail.
|
Indeed the favicon is still being served (I checked with a fresh favicon). |
…ns_to_add_a_custom_favicon
closes #140