New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] skip conversion of SOC targets minima or maxima are defined as Sensors #1047
Merged
Flix6x
merged 8 commits into
main
from
fix/planning/skip-conversion-when-soc-target-maxima-minima-are-sensors
May 6, 2024
Merged
[fix] skip conversion of SOC targets minima or maxima are defined as Sensors #1047
Flix6x
merged 8 commits into
main
from
fix/planning/skip-conversion-when-soc-target-maxima-minima-are-sensors
May 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y are defined from sensors. Signed-off-by: Victor Garcia Reolid <victor@seita.nl>
…-maxima-minima-are-sensors
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
Signed-off-by: F.N. Claessen <felix@seita.nl>
…ning/skip-conversion-when-soc-target-maxima-minima-are-sensors
Flix6x
added
Units
Deals with unit conversion
and removed
Still Needs Changelog Entry
labels
May 6, 2024
Flix6x
approved these changes
May 6, 2024
Flix6x
deleted the
fix/planning/skip-conversion-when-soc-target-maxima-minima-are-sensors
branch
May 6, 2024 10:04
Flix6x
pushed a commit
that referenced
this pull request
May 6, 2024
…ima are defined as Sensors (#1047) * fix: skip conversion of soc_targets, soc_minima and soc_maxima if they are defined from sensors. Signed-off-by: Victor Garcia Reolid <victor@seita.nl> * add test Signed-off-by: Victor Garcia Reolid <victor@seita.nl> * style: small review fixes Signed-off-by: F.N. Claessen <felix@seita.nl> * fix: remove confusing attribute for SoC sensors Signed-off-by: F.N. Claessen <felix@seita.nl> * docs: clarify fixture Signed-off-by: F.N. Claessen <felix@seita.nl> * docs: changelog entry Signed-off-by: F.N. Claessen <felix@seita.nl> --------- Signed-off-by: Victor Garcia Reolid <victor@seita.nl> Signed-off-by: F.N. Claessen <felix@seita.nl> Co-authored-by: F.N. Claessen <felix@seita.nl> (cherry picked from commit db69234)
Flix6x
pushed a commit
that referenced
this pull request
May 7, 2024
…ima are defined as Sensors (#1047) * fix: skip conversion of soc_targets, soc_minima and soc_maxima if they are defined from sensors. Signed-off-by: Victor Garcia Reolid <victor@seita.nl> * add test Signed-off-by: Victor Garcia Reolid <victor@seita.nl> * style: small review fixes Signed-off-by: F.N. Claessen <felix@seita.nl> * fix: remove confusing attribute for SoC sensors Signed-off-by: F.N. Claessen <felix@seita.nl> * docs: clarify fixture Signed-off-by: F.N. Claessen <felix@seita.nl> * docs: changelog entry Signed-off-by: F.N. Claessen <felix@seita.nl> --------- Signed-off-by: Victor Garcia Reolid <victor@seita.nl> Signed-off-by: F.N. Claessen <felix@seita.nl> Co-authored-by: F.N. Claessen <felix@seita.nl> (cherry picked from commit db69234)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO