Allow reading beliefs from xlsx files, and from data files with multiple headers #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhoening
approved these changes
Apr 22, 2021
There was a problem hiding this comment.
One comment about source:
Now we simply take the "Seita" source. Often, the data is passed to us by the client or some other third party. Wouldn't it be better to be able to name them as the source?
Concretely, we could allow to pass in a source ID or name, and possibly create the source if it doesn't exist.
up existing sources
|
Great suggestion. While implementing your suggestion I also found a missing primary key. |
nhoening
requested changes
Apr 23, 2021
…e get_current_object to get the User object
nhoening
approved these changes
Apr 29, 2021
Co-authored-by: Nicolas Höning <iam@nicolashoening.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.