Skip to content

Commit

Permalink
Bug: logging in after clearing session redirects to clearing session (#…
Browse files Browse the repository at this point in the history
…112)

Prevent user from being logged out when clearing the session.


* Create draft PR for #28

* More session keys to avoid clearing

* Changelog entry

Co-authored-by: Flix6x <Flix6x@users.noreply.github.com>
Co-authored-by: F.N. Claessen <felix@seita.nl>
Co-authored-by: Felix Claessen <30658763+Flix6x@users.noreply.github.com>
  • Loading branch information
4 people committed May 1, 2021
1 parent 3dc87dd commit 52a8f41
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
4 changes: 4 additions & 0 deletions documentation/changelog.rst
Expand Up @@ -10,6 +10,10 @@ New features
-----------
* Allow plugins to overwrite UI routes and customise the teaser on the login form [see `PR #106 <http://www.github.com/SeitaBV/flexmeasures/pull/106>`_]

Bugfixes
-----------
* Prevent logging out user when clearing the session [see `PR #112 <http://www.github.com/SeitaBV/flexmeasures/pull/112>`_]

Infrastructure / Support
----------------------
* Make assets use MW as their default unit and enforce that in CLI, as well (API already did) [see `PR #108 <http://www.github.com/SeitaBV/flexmeasures/pull/108>`_]
Expand Down
4 changes: 3 additions & 1 deletion flexmeasures/ui/utils/view_utils.py
Expand Up @@ -91,7 +91,9 @@ def render_flexmeasures_template(html_filename: str, **variables):

def clear_session():
for skey in [
k for k in session.keys() if k not in ("_id", "user_id", "csrf_token")
k
for k in session.keys()
if k not in ("_fresh", "_id", "_user_id", "csrf_token", "fs_cc", "fs_paa")
]:
current_app.logger.info(
"Removing %s:%s from session ... " % (skey, session[skey])
Expand Down

0 comments on commit 52a8f41

Please sign in to comment.