Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Dockerfile and action #1108

Closed
wants to merge 13 commits into from
Closed

Conversation

Gauvino
Copy link

@Gauvino Gauvino commented Mar 3, 2024

  • Update debian from 11 to 12
  • Fix command on README.md
  • Rework Dockerfile for reliability and better syntax overall
  • Update actions/create-release to softprops/action-gh-release since the repo is deprecated
  • Update CI actions to latest version
  • Update pyinstaller from 5.13 to 6.6
  • Added cleanup command to Dockerfile

@Gauvino
Copy link
Author

Gauvino commented Mar 3, 2024

Proof of building with new dockerfile
Docker_Desktop_dGkx69J4Ep

@ilike2burnthing
Copy link
Contributor

There are at least a couple of open PRs for UC regarding the update to 3.12:
ultrafunkamsterdam/undetected-chromedriver#1641
ultrafunkamsterdam/undetected-chromedriver#1766

I'm not sure what else there or here would need to be updated.

@Asthowen
Copy link
Contributor

Asthowen commented Mar 3, 2024

There's another problem, py312-pip doesn't exist in the FreeBSD repositories, that's why I left py39-pip, which is the latest version available.

@Gauvino
Copy link
Author

Gauvino commented Mar 3, 2024

There's another problem, py312-pip doesn't exist in the FreeBSD repositories, that's why I left py39-pip, which is the latest version available.

there is no possibility on freebsd to install further version than just 3.9 ?

@Asthowen
Copy link
Contributor

Asthowen commented Mar 3, 2024

Python 3.12 isn't in the repositories either (the latest version available for python is 3.11), so unless you install it manually...

@MastaG
Copy link

MastaG commented Mar 5, 2024

I'm running it on Python 3.12 using the official fedora:39 image for testing purposes.
See: #1109 (comment)
The only warning I'm getting when running using Fedora 39 Python 3.12 would be:

Mar 05 14:28:46 fedora.tno-187.lan flaresolverr[931688]: /app/utils.py:293: SyntaxWarning: invalid escape sequence '\d'
Mar 05 14:28:46 fedora.tno-187.lan flaresolverr[931688]:   pattern = '\d+\.\d+\.\d+\.\d+'

This doesn't occur on Debian's python 3.11.

@Gauvino Gauvino changed the title Update to py3.12, refactor Dockerfile and action Refactor Dockerfile and action May 3, 2024
@Gauvino
Copy link
Author

Gauvino commented May 3, 2024

Proof of building docker image
image

@Gauvino
Copy link
Author

Gauvino commented May 3, 2024

Could you look at this @ilike2burnthing ?

@Asthowen
Copy link
Contributor

Asthowen commented May 3, 2024

On FreeBSD the python311 package is available but not the py311-pip package. So you have to install pip manually or stay on python 3.9 (most Python modules are not available in FreeBSD repositories or are not available for Python 3.11).

@Gauvino
Copy link
Author

Gauvino commented May 3, 2024

So we keep py39 for FreeBSD ?

@Asthowen
Copy link
Contributor

Asthowen commented May 3, 2024

That's what I'd do, but ideally I'd use pyenv (which I suppose will be possible with #567).

@Gauvino
Copy link
Author

Gauvino commented May 3, 2024

That's what I'd do, but ideally I'd use pyenv (which I suppose will be possible with #567).

Do you think I could add the pyenv change to my PR ?

@ilike2burnthing
Copy link
Contributor

Some version of #1163 will be happening first, then we can revisit.

 - Update debian from 11 to 12
 - Rework Dockerfile for reliability and better syntax overall
 - Update actions/create-release to softprops/action-gh-release since the repo is deprecated
 - Update CI actions to latest version
 - Update pyinstaller from 5.13 to 6.6
 - Added cleanup command to Dockerfile
@Gauvino
Copy link
Author

Gauvino commented May 17, 2024

Been running this PR for about 1 month without any issue, so if your steel waiting before #1163 is merged no problem but please consider trying this PR and review it please!

Gauvino and others added 8 commits May 24, 2024 18:36
 - Update debian from 11 to 12
 - Rework Dockerfile for reliability and better syntax overall
 - Update actions/create-release to softprops/action-gh-release since the repo is deprecated
 - Update CI actions to latest version
 - Update pyinstaller from 5.13 to 6.6
 - Added cleanup command to Dockerfile

Update to 3.3.20
…err#1199)

* Fix occasional headless issue on Linux when set to "false"

- Add a variable containing the current platform
- Check if the platform is "nt" (Windows) before closing the driver

* Update CHANGELOG.md

---------

Co-authored-by: ilike2burnthing <59480337+ilike2burnthing@users.noreply.github.com>
…err#1199)

* Fix occasional headless issue on Linux when set to "false"

- Add a variable containing the current platform
- Check if the platform is "nt" (Windows) before closing the driver

* Update CHANGELOG.md

---------

Co-authored-by: ilike2burnthing <59480337+ilike2burnthing@users.noreply.github.com>
ilike2burnthing and others added 4 commits May 24, 2024 18:53
…err#1199)

* Fix occasional headless issue on Linux when set to "false"

- Add a variable containing the current platform
- Check if the platform is "nt" (Windows) before closing the driver

* Update CHANGELOG.md

---------

Co-authored-by: ilike2burnthing <59480337+ilike2burnthing@users.noreply.github.com>
 - Update debian from 11 to 12
 - Rework Dockerfile for reliability and better syntax overall
 - Update actions/create-release to softprops/action-gh-release since the repo is deprecated
 - Update CI actions to latest version
 - Update pyinstaller from 5.13 to 6.6
 - Added cleanup command to Dockerfile

Update to 3.3.20

Update to 3.3.20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants