feat: Edge V2 migration opt-in, capacity budget for migration #3881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
khvn26
force-pushed
the
feat/environments-v2-opt-in
branch
from
6b73235
to
e7dca08
Compare
|
Uffizzi Preview |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3881 +/- ##
==========================================
+ Coverage 96.01% 96.17% +0.16%
==========================================
Files 1138 1141 +3
Lines 36443 36457 +14
==========================================
+ Hits 34992 35064 +72
+ Misses 1451 1393 -58 ☔ View full report in Codecov by Sentry. |
khvn26
force-pushed
the
feat/environments-v2-opt-in
branch
from
e7dca08
to
a281a7b
Compare
khvn26
force-pushed
the
feat/environments-v2-opt-in
branch
from
119df5e
to
66a64b0
Compare
khvn26
requested review from
a team,
gagantrivedi and
matthewelwell
and removed request for
a team
5 tasks
matthewelwell
approved these changes
May 15, 2024
khvn26
force-pushed
the
feat/environments-v2-opt-in
branch
from
bed542b
to
42991cb
Compare
github-actions
bot
added
front-end
gagantrivedi
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Naming
IdentityOverridesV2MigrationStatusenumeration is renamed toEdgeV2MigrationStatus.Settings
Added:
EDGE_V2_MIGRATION_READ_CAPACITY_BUDGET: controls how much read capacity is allowed during migration toenvironments_v2. Default value is0. The idea is to increase it to a sensible amount whenever Edge V2 is live.Business logic
Renamed:
Project.identity_overrides_v2_migration_status->Project.edge_v2_migration_status.Modified:
DynamoIdentityWrapper.iter_all_items_paginatednow acceptscapacity_budgetargument. If the budget is reached or exceeded during iteration, it raises aCapacityBudgetExceededexception. Ifcapacity_budgetis0, the error is raised before any request to DynamoDB is made.Added:
Project.edge_v2_read_capacity_budgetoverrides theEDGE_V2_MIGRATION_READ_CAPACITY_BUDGETfor the given project. Field value isnullby default.EdgeV2MigrationStatus.INCOMPLETEmarks projects that have exceeded the read capacity budget during migration and have only environment documents migrated. Identity override migration is completely skipped for such projects.API
edge_v2_migration_statustoprojectendpoints so the migration can be triggered via REST API.edge_v2_read_capacity_budgetis only modifiable via Django admin page.How did you test this code?
All code covered with unit tests.