Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support nullable annotations #622

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jonasdoerr
Copy link

When I started using FlaUI, I realized that methods and properties I didn't expect to return null. So I thought nullable annotations could be useful.

  • Enabled nullable annotations for Core/UIA2/UIA3, upgraded to C# 11 for nameof(parameter).
  • Created internal fake code analysis attributes for TFMs not providing them, e.g. .NET Framework and .NET Standard 2.0.
  • Nearly no changes in behaviour, only in a few cases where avoiding a null-ref exception was reasonable.
  • Of course, there are still many chances for null-ref in the codebase, but we have warnings now.

@jonasdoerr
Copy link
Author

The error in the build pipeline is likely to be caused by the version of the NUnit engine. Some versions had that issue that they throw an exception if they find an installed .NET runtime they don't know. Therefore, you can break a pipeline by just installing the .NET 8 runtime or SDK, without touching the build script. Propably, updating the NUnit console runner could fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant