SparseMatrixCSR extension #864
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
termi-official
force-pushed
the
do/sparsematrixcsr-assembly-extension
branch
from
49d273a
to
27d1980
Compare
termi-official
force-pushed
the
do/sparsematrixcsr-assembly-extension
branch
from
27d1980
to
0c3efc8
Compare
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #864 +/- ##
==========================================
+ Coverage 93.29% 93.34% +0.05%
==========================================
Files 36 37 +1
Lines 5235 5291 +56
==========================================
+ Hits 4884 4939 +55
- Misses 351 352 +1 ☔ View full report in Codecov by Sentry. |
termi-official
added
the
awaiting review
termi-official
removed
the
awaiting review
termi-official
force-pushed
the
do/sparsematrixcsr-assembly-extension
branch
from
94ece96
to
8102774
Compare
termi-official
added
the
awaiting review
termi-official
changed the title
KnutAM
reviewed
Dec 28, 2023
ext/FerriteSparseMatrixCSR.jl
Outdated
Comment on lines
40
to
42
| if !iszero(Ke[Kerow, permutation[i]]) | ||
| _missing_sparsity_pattern_error(Krow, sorteddofs[i]) | ||
| end |
There was a problem hiding this comment.
Seems like also this loop is never active either in tests, which seems related to above.
There was a problem hiding this comment.
I think I need @fredrikekre to help out here. The logic is the same as the for csc assembly, I just swapped the indices. I guess this is the same case as above, that we handle "too small sparse matrices"?
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #848 and #628 . This should show how we could assemble into custom sparse matrix formats.
TODO