Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort new fields in lexicographic order during update #4223

Merged
merged 9 commits into from May 15, 2024

Conversation

wazir-ahmed
Copy link
Contributor

Description

Closes #2038.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@wazir-ahmed wazir-ahmed requested a review from a team as a code owner April 5, 2024 19:27
Copy link

codecov bot commented Apr 5, 2024

Codecov Report

Attention: Patch coverage is 88.52989% with 71 lines in your changes are missing coverage. Please review.

Project coverage is 74.12%. Comparing base (fb4f384) to head (3e04a0d).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4223      +/-   ##
==========================================
- Coverage   75.33%   74.12%   -1.22%     
==========================================
  Files         323      323              
  Lines       22408    22355      -53     
==========================================
- Hits        16882    16571     -311     
- Misses       4306     4574     +268     
+ Partials     1220     1210      -10     
Files Coverage Δ
internal/handler/common/update_array_operators.go 88.05% <87.09%> (+1.86%) ⬆️
internal/handler/common/update.go 91.69% <89.48%> (+1.14%) ⬆️

... and 36 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 67.14% <88.52%> (-1.59%) ⬇️
hana-1 ?
integration 67.14% <88.52%> (-1.64%) ⬇️
mongodb-1 5.13% <0.00%> (+0.01%) ⬆️
mysql-1 ?
mysql-2 ?
mysql-3 ?
postgresql-1 44.95% <55.41%> (-7.01%) ⬇️
postgresql-2 43.87% <49.43%> (-9.63%) ⬇️
postgresql-3 42.77% <52.98%> (-10.78%) ⬇️
postgresql-4 41.23% <26.49%> (+0.41%) ⬆️
postgresql-5 43.34% <25.68%> (-2.51%) ⬇️
sqlite-1 43.92% <55.41%> (-7.11%) ⬇️
sqlite-2 43.19% <49.43%> (-9.43%) ⬇️
sqlite-3 42.01% <52.98%> (-10.67%) ⬇️
sqlite-4 40.62% <26.49%> (+0.51%) ⬆️
sqlite-5 42.47% <25.68%> (-2.34%) ⬇️
unit 31.96% <0.00%> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@wazir-ahmed wazir-ahmed marked this pull request as draft April 6, 2024 02:38
@wazir-ahmed wazir-ahmed force-pushed the sorted-update branch 2 times, most recently from 3d54c87 to 893fbaa Compare April 8, 2024 03:53
@wazir-ahmed wazir-ahmed marked this pull request as ready for review April 10, 2024 10:05
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution 🤗

This is a huge change, we are taking time to review it carefully. Meanwhile I have a few questions 😃

internal/handler/common/update.go Outdated Show resolved Hide resolved
internal/handler/common/update.go Outdated Show resolved Hide resolved
integration/findandmodify_compat_test.go Show resolved Hide resolved
internal/handler/common/update.go Show resolved Hide resolved
internal/handler/common/update.go Show resolved Hide resolved
internal/handler/common/update.go Show resolved Hide resolved
internal/handler/common/update.go Show resolved Hide resolved
internal/handler/common/update.go Show resolved Hide resolved
integration/findandmodify_compat_test.go Show resolved Hide resolved
@chilagrow chilagrow added the code/chore Code maintenance improvements label May 8, 2024
Copy link
Contributor

@chilagrow chilagrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Huge thanks for your contribution 🤗

@chilagrow chilagrow enabled auto-merge (squash) May 8, 2024 02:01
@chilagrow chilagrow merged commit 2665671 into FerretDB:main May 15, 2024
30 of 32 checks passed
@AlekSi
Copy link
Member

AlekSi commented May 15, 2024

Thank you!

@AlekSi AlekSi added code/enhancement Some user-visible feature could work better and removed code/chore Code maintenance improvements labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/enhancement Some user-visible feature could work better
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Sort document fields in lexicographic/numeric order
3 participants