Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore apiVersion field from StableAPI #4067

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Evengard
Copy link

@Evengard Evengard commented Feb 12, 2024

Description

When using the StableAPI, clients sends along an apiVersion and some other fields, which aren't recognized by FerretDB. Otherwise the command is fine. Just ignoring them seems to work fine. Tested with MongoDB.Driver (C#) 2.23.1

Mimicked the LSID ignore code, except defined the actual string and bool types for them.

Closes #3121.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@AlekSi AlekSi added the community Issues and PRs assigned to community members label Feb 15, 2024
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should do FerretDB/dance#769 first

Copy link

codecov bot commented Feb 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (282c8e1) 75.80% compared to head (473c48c) 74.58%.
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4067      +/-   ##
==========================================
- Coverage   75.80%   74.58%   -1.22%     
==========================================
  Files         341      342       +1     
  Lines       21750    21809      +59     
==========================================
- Hits        16487    16266     -221     
- Misses       3980     4291     +311     
+ Partials     1283     1252      -31     
Files Coverage Δ
internal/handler/common/count.go 100.00% <ø> (ø)
internal/handler/common/delete_params.go 100.00% <ø> (ø)
internal/handler/common/distinct.go 82.45% <ø> (ø)
internal/handler/common/find.go 100.00% <ø> (ø)
internal/handler/common/findandmodify.go 78.43% <ø> (ø)
internal/handler/common/insert.go 100.00% <ø> (ø)
internal/handler/common/update_params.go 100.00% <ø> (ø)

... and 28 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 66.67% <ø> (-1.56%) ⬇️
hana-1 ?
integration 66.67% <ø> (-1.58%) ⬇️
mongodb-1 4.81% <ø> (-0.02%) ⬇️
mysql-1 ?
mysql-2 ?
mysql-3 ?
postgresql-1 49.57% <ø> (-0.22%) ⬇️
postgresql-2 46.57% <ø> (-0.14%) ⬇️
postgresql-3 47.81% <ø> (-0.16%) ⬇️
sqlite-1 48.91% <ø> (-0.16%) ⬇️
sqlite-2 45.70% <ø> (-0.11%) ⬇️
sqlite-3 47.03% <ø> (-0.07%) ⬇️
unit 32.52% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Issues and PRs assigned to community members
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

We should ignore Stable API parameters
2 participants