Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test script for capped collection behavior #4022

Closed
wants to merge 9 commits into from

Conversation

b1ron
Copy link
Contributor

@b1ron b1ron commented Jan 30, 2024

Description

Closes #4023.

Closes FerretDB/dance/issues/753.

The behavior for capped collections is not consistent with MongoDB. Documents should be removed in a FIFO manner.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@mergify mergify bot assigned b1ron Jan 30, 2024
Copy link

codecov bot commented Jan 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.96%. Comparing base (c299c53) to head (8080370).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4022      +/-   ##
==========================================
- Coverage   74.70%   73.96%   -0.74%     
==========================================
  Files         339      339              
  Lines       22910    22910              
==========================================
- Hits        17114    16946     -168     
- Misses       4477     4665     +188     
+ Partials     1319     1299      -20     

see 18 files with indirect coverage changes

Flag Coverage Δ
filter-true 67.36% <ø> (-0.84%) ⬇️
hana-1 ?
integration 67.36% <ø> (-0.84%) ⬇️
mongodb-1 5.13% <ø> (ø)
postgresql-1 46.43% <ø> (-0.10%) ⬇️
postgresql-2 49.55% <ø> (-0.11%) ⬇️
postgresql-3 49.82% <ø> (-0.02%) ⬇️
sqlite-1 45.69% <ø> (-0.06%) ⬇️
sqlite-2 48.78% <ø> (-0.01%) ⬇️
sqlite-3 49.00% <ø> (ø)
unit 32.69% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@b1ron b1ron changed the title Add test script for capped collection issue Add test script for capped collection behavior Jan 30, 2024
@b1ron b1ron closed this by deleting the head repository May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do not merge PRs that should not be merged
Projects
Status: In progress
Development

Successfully merging this pull request may close these issues.

Capped collections do not overwrite the oldest documents when size is reached Investigate cappeda.js failure
2 participants