Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maxAwaitTimeMs tests #3968

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

noisersup
Copy link
Member

@noisersup noisersup commented Jan 11, 2024

Description

Closes #2983.

Readiness checklist

  • I added/updated unit tests (and they pass).
  • I added/updated integration/compatibility tests (and they pass).
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (44500e7) 74.22% compared to head (4eb36a5) 74.39%.
Report is 12 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3968      +/-   ##
==========================================
+ Coverage   74.22%   74.39%   +0.16%     
==========================================
  Files         330      329       -1     
  Lines       25960    25881      -79     
==========================================
- Hits        19269    19253      -16     
+ Misses       5556     5478      -78     
- Partials     1135     1150      +15     

see 24 files with indirect coverage changes

Flag Coverage Δ
filter-false ?
filter-true 70.90% <ø> (-0.12%) ⬇️
hana-1 ?
integration 70.90% <ø> (-0.14%) ⬇️
mongodb-1 5.29% <ø> (+0.12%) ⬆️
mysql-1 ?
postgresql-1 50.18% <ø> (-12.97%) ⬇️
postgresql-2 52.11% <ø> (+1.85%) ⬆️
postgresql-3 50.62% <ø> (-1.48%) ⬇️
sqlite-1 49.35% <ø> (-12.82%) ⬇️
sqlite-2 51.20% <ø> (+1.82%) ⬆️
sqlite-3 49.82% <ø> (-1.47%) ⬇️
unit 30.76% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@noisersup noisersup marked this pull request as ready for review January 17, 2024 18:59
@noisersup noisersup requested a review from a team as a code owner January 17, 2024 18:59
@noisersup noisersup added this to the Next milestone Jan 17, 2024
@noisersup noisersup added the code/enhancement Some user-visible feature could work better label Jan 17, 2024
@noisersup noisersup requested review from a team and henvic January 17, 2024 19:00
@AlekSi
Copy link
Member

AlekSi commented Jan 29, 2024

On hold for now

@AlekSi AlekSi marked this pull request as draft January 29, 2024 07:52
@AlekSi AlekSi modified the milestones: v1.19.0, Next Jan 29, 2024
@AlekSi AlekSi removed request for a team, AlekSi, henvic and rumyantseva January 29, 2024 16:17
Copy link
Member

@AlekSi AlekSi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dummy review to remove notification

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/enhancement Some user-visible feature could work better
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Propagate maxTimeMS of find and aggregate to getMore
2 participants