Fix awaitData cursors
#3961
Fix awaitData cursors
#3961
Conversation
|
|
||
| collName := testutil.CollectionName(t) | ||
|
|
||
| ready <- struct{}{} |
There was a problem hiding this comment.
We are not ready with the setup yet at this point. This should be moved lower
| @@ -308,6 +308,122 @@ func TestCursorsTailableAwaitData(t *testing.T) { | |||
| }) | |||
| } | |||
|
|
|||
| func TestCursorsTailableAwaitDataAfterInsertStress(t *testing.T) { | |||
| if !setup.IsMongoDB(t) { | |||
| t.Skip("https://github.com/FerretDB/FerretDB/pull/3961") | |||
There was a problem hiding this comment.
We should link to issues, not to PRs.
And can we use expected failure instead?
There was a problem hiding this comment.
Most of the subtests pass, and usually one of them fails, so not really
| teststress.Stress(t, func(ready chan<- struct{}, start <-chan struct{}) { | ||
| testID := count.Add(1) | ||
|
|
||
| t.Run(fmt.Sprint(testID), func(t *testing.T) { |
There was a problem hiding this comment.
t.Run doesn't run in parallel, effectively un-stressing the test
There was a problem hiding this comment.
From my testing it seems it's not
There was a problem hiding this comment.
Ok, please explain how t.Run works then
| var firstBatch *types.Array | ||
| firstBatch, cursorID = getFirstBatch(t, res) |
There was a problem hiding this comment.
| var firstBatch *types.Array | |
| firstBatch, cursorID = getFirstBatch(t, res) | |
| var firstBatch *types.Array | |
| firstBatch, cursorID := getFirstBatch(t, res) |
There is no need to define cursorID above either.
(I wonder why everyone suddenly started using var instead of short variables assignments…)
noisersup
changed the title
awaitData cursorsawaitData cursors
noisersup
force-pushed
the
fluky-tailable-3945
branch
from
cd27358
to
a7ac09b
Compare
|
On hold for now |
Description
Closes #3957.
Readiness checklist
task all, and it passed.@FerretDB/core), Milestone (Next), Labels, Project and project's Sprint fields.