Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply JsonTypeInfo.Value usages from Jackson 3.0 #3953 #600

Merged

Conversation

JooHyukKim
Copy link
Member

Fixes breakage when PR FasterXML/jackson-databind#3953 is merged.

pom.xml Outdated
@@ -41,6 +41,12 @@ alternative support for serializing POJOs as XML and deserializing XML as pojos.
<!-- Extends Jackson (jackson-mapper); requires Stax API (and implementation on
deploy time), Stax2 API.
-->
<dependency>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not need to do this, as long as jackson-base version 2.16.0-SNAPSHOT has dependencies to 2.16.0-SNAPSHOT. You can also re-build snapshot locally for jackson-databind (with ./mvnw clean install) and that version should be used without other workarouns.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, it works without this <dependency> prop, thanksss 🥹

@JooHyukKim JooHyukKim marked this pull request as ready for review May 24, 2023 22:42
@cowtowncoder cowtowncoder merged commit b6a6fde into FasterXML:2.16 May 26, 2023
3 checks passed
@JooHyukKim JooHyukKim deleted the test-local-build-JsonTypeInfo.Value branch May 29, 2023 13:50
@JooHyukKim JooHyukKim restored the test-local-build-JsonTypeInfo.Value branch May 29, 2023 13:51
@JooHyukKim JooHyukKim deleted the test-local-build-JsonTypeInfo.Value branch May 29, 2023 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants