Fix DMenuOptionCVar tripping over itself

[Tenrys]

RunConsoleCommand does set the CVar a frame later, but the panel's Think runs right after OnChecked, and by that point the CVar hasn't been updated yet, so it sets itself back to its previous value.

This works but I feel like it's a bit too dirty?

Also remove deprecated use of GetConVarString

[robotboy655]

Are you able to present a case where this issue actually happens?

I have tried adding some print()s when the convar value is being set and read, and I am not noticing any issues with the spawnmenu menubar setting the cvar, either by clicking the option to set cvar, or by setting the cvar from the console.

[robotboy655]

You really can't be using local out-of-scope variables for objects that can have multiple instances present at the same time.

[Tenrys]

Right, just to be sure, would PANEL.JustChecked work out better then? I do feel like the solution I presented is a bit dirty, but I can't think of anything better on the spot.

[Tenrys]

With the following code:

local frame = vgui.Create("DFrame")
frame:SetSize(300, 300)
frame:SetPos(ScrW() - 350, 50)

local panel = vgui.Create("DPanel", frame)
panel:Dock(FILL)
panel:DockPadding(10, 10, 10, 10)
panel.OpenSubMenu = function() end

local option = vgui.Create("DMenuOptionCVar", panel)
option:SetConVar("cl_showfps")
option:SetText("Show FPS")

I doubt the way I'm using this control has anything to do with how it functions, but here's how it works for me on x86-64, and there is also a comparison with my fix.

gmod_swAP9c7yyV_fix.mp4