Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lua/autorun/game_hl2.lua rewrite #2061

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

unknown-gd
Copy link
Contributor

I have long wanted to rewrite this file to give people ability to localize weapon, ammo and entity names, as well as reduce file execution time by reducing amount of global calls. Also, I made a few small corrections and standardized style of weapon names.

image
image

image
image

image
image

image

@robotboy655 robotboy655 added the Enhancement The pull request enhances current functionality. label Feb 29, 2024
end

Category = "Half-Life 2"
local category = "Half-Life 2"
Copy link

@Blueberryy Blueberryy Mar 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Localization is working with Categories? If so, please add them in file for Chinese localizators.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Chinese is possible to localize game titles?!

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rechecked, and I don't think it makes sense, because 100% of the other code uses static "Half-Life 2" string, which can be confusing. This requires a more complex solution than replacing a single category name.. I will continue working on game localization, I think I will let you know when a complete and quality localization of the game will be possible.

@NovaDiablox
Copy link
Contributor

Any updates to this pr?

@unknown-gd
Copy link
Contributor Author

Any updates to this pr?

Rubat decided to rewrite this file very timely and broke all my changes, when I have free time I will rewrite this.

@NovaDiablox
Copy link
Contributor

Any updates to this pr?

Rubat decided to rewrite this file very timely and broke all my changes, when I have free time I will rewrite this.

Great thx!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement The pull request enhances current functionality.
Projects
None yet
4 participants