player_manager.GetPlayerClassTable(Player ply) #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A method to access a player class table more quickly. While it's nothing new - as we can already access the table of player classes and index it - it's a bit more elegant and performant, as it doesn't have to create a deep copy of the whole table.
|
Wouldn't it be more efficient to copy the single element instead of the entire |
|
Oh my. I thought this was exactly what I did, but now that I double-checked, I still copy the entire Type table, even though my description suggests otherwise. |
|
Updated & fixed, hopefully. I should keep my eyes peeled next time... Thanks for noticing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a method to access player class definition tables more quickly.
Instead of doing this:
We can do this:
When I access the class table, I still create a deep copy of the table before it is returned, since we don't want players to mess with the internal tables! However, it should be more performant, because I avoid copying the entire
Typetable.It's a very simple change that I came up with while working with player classes for my gamemode, but I'd be glad to contribute even something as small as this.